-
Notifications
You must be signed in to change notification settings - Fork 2k
Test Case added. Issue #1238 #5549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@Sreejan100 can you please fix build failures ? |
@rthadur from where should I know what are these build failures? |
|
@rthadur it is asking sso username and password |
@rthadur hey I think you can have a look at the file changed. By looking at that can you tell which part may causing the build failure? |
`ERROR: (max-line-length) /workspace/tfjs-layers/src/engine/training_dataset_test.ts[3424, 1]: Exceeds maximum line length of 80
|
@Sreejan100 any update ? |
@rthadur I am not able to get hold of the error. Can you tell me what mistake I have made? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 0 of 1 approvals obtained (waiting on @caisq)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Sreejan100 Thank you for contributing. The issue #1238 asks for tests that cover the error cases when the input shape does not match the model. I think your tests only covers various input and output count, not the same as what the issue is requesting. Can you see if you can rewrite these tests to cover error handling? thanks
Reviewable status: 0 of 1 approvals obtained
Test case with 4 input 1 output, 1 metric, no validation, no batch sizes specified added.
Test case with 3 input 1 output, 1 metric, no validation, no batch sizes specified added.
Test case with 2 input 2 output, 1 metric, no validation, no batch sizes specified added.
Issue no #1238
This change is