Skip to content

Test Case added. Issue #1238 #5549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Sreejan100
Copy link

@Sreejan100 Sreejan100 commented Aug 29, 2021

Test case with 4 input 1 output, 1 metric, no validation, no batch sizes specified added.
Test case with 3 input 1 output, 1 metric, no validation, no batch sizes specified added.
Test case with 2 input 2 output, 1 metric, no validation, no batch sizes specified added.
Issue no #1238


This change is Reviewable

@google-cla google-cla bot added the cla: yes label Aug 29, 2021
@rthadur
Copy link
Contributor

rthadur commented Sep 13, 2021

@Sreejan100 can you please fix build failures ?

@rthadur rthadur requested a review from caisq September 13, 2021 19:10
@Sreejan100
Copy link
Author

@rthadur from where should I know what are these build failures?

@rthadur
Copy link
Contributor

rthadur commented Sep 13, 2021

@Sreejan100
Copy link
Author

@rthadur it is asking sso username and password

@Sreejan100
Copy link
Author

@rthadur hey I think you can have a look at the file changed. By looking at that can you tell which part may causing the build failure?

@rthadur
Copy link
Contributor

rthadur commented Sep 13, 2021

`ERROR: (max-line-length) /workspace/tfjs-layers/src/engine/training_dataset_test.ts[3424, 1]: Exceeds maximum line length of 80

  • "lint-tfjs-layers": ERROR: (max-line-length) /workspace/tfjs-layers/src/engine/training_dataset_test.ts[3534, 1]: Exceeds maximum line length of 80
  • "lint-tfjs-layers": ERROR: (max-line-length) /workspace/tfjs-layers/src/engine/training_dataset_test.ts[3537, 1]: Exceeds maximum line length of 80`

@rthadur
Copy link
Contributor

rthadur commented Sep 23, 2021

@Sreejan100 any update ?

@Sreejan100
Copy link
Author

@rthadur I am not able to get hold of the error. Can you tell me what mistake I have made?

Copy link

@ed738 ed738 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 0 of 1 approvals obtained (waiting on @caisq)

@caisq caisq requested review from lina128 and removed request for caisq July 22, 2022 14:50
@lina128 lina128 requested review from pyu10055 and removed request for lina128 July 22, 2022 16:31
Copy link
Collaborator

@pyu10055 pyu10055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sreejan100 Thank you for contributing. The issue #1238 asks for tests that cover the error cases when the input shape does not match the model. I think your tests only covers various input and output count, not the same as what the issue is requesting. Can you see if you can rewrite these tests to cover error handling? thanks

Reviewable status: 0 of 1 approvals obtained

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants