fix(bridge): instanceof Promise
was not giving correct results when run with Jest
#1737
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Bridge's error conversion logic now uses the
isPromise
node's utility function instead of aninstanceof Promise
check.The later is prone to Jest's globals differ from Node globals bug (i.e.
somePromise instanceof Promise
may evaluate tofalse
in some contexts), which would result in not converting errors thrown from the Rust side when Worker is run in Jest.This has been causing Jest tests to fail with
ShutdownError: Worker has been shutdown
errors, using TS SDK 1.12.0.