Skip to content

chore: Update Core in prep for v1.12.0 release #1735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 1, 2025
Merged

chore: Update Core in prep for v1.12.0 release #1735

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d499e44
chore: Update Core in prep for v1.12.0 release
mjameswh Jun 30, 2025
c85fd1b
Need latest rust
mjameswh Jul 1, 2025
aac3eb5
Fix lint/build errors
mjameswh Jul 1, 2025
f4ada60
Missing clippy
mjameswh Jul 1, 2025
a8a3602
Just upgrade rust, don't be specifc on rust version number
mjameswh Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,11 @@ jobs:
version: '23.x'
repo-token: ${{ secrets.GITHUB_TOKEN }}

- name: Upgrade Rust to at least 1.88.0
uses: dtolnay/rust-toolchain@stable
with:
toolchain: 1.88.0

- name: Rust Cargo and Build cache
if: steps.cached-artifact.outputs.cache-hit != 'true'
uses: Swatinem/rust-cache@v2
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/conventions.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,12 @@ jobs:
version: '23.x'
repo-token: ${{ secrets.GITHUB_TOKEN }}

- name: Upgrade Rust to at least 1.88.0
uses: dtolnay/rust-toolchain@stable
with:
toolchain: 1.88.0
components: clippy

- name: Rust Cargo and Build cache
uses: Swatinem/rust-cache@v2
with:
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,11 @@ jobs:
version: '23.x'
repo-token: ${{ secrets.GITHUB_TOKEN }}

- name: Upgrade Rust to at least 1.88.0
uses: dtolnay/rust-toolchain@stable
with:
toolchain: 1.88.0

# FIXME: Setup volumes so that we can benefit from the cache in the Docker-build scenario.
# Or maybe just get rid of the cache entirely if it doesn't have sufficient benefits.
- name: Rust Cargo and Build cache
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/stress.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,11 @@ jobs:
version: '23.x'
repo-token: ${{ secrets.GITHUB_TOKEN }}

- name: Upgrade Rust to at least 1.88.0
uses: dtolnay/rust-toolchain@stable
with:
toolchain: 1.88.0

- name: Rust Cargo and Build cache
uses: Swatinem/rust-cache@v2
with:
Expand Down
2 changes: 1 addition & 1 deletion packages/core-bridge/sdk-core
Open in desktop
Submodule sdk-core updated 71 files
+6 −1 .cargo/config.toml
+38 −9 .github/workflows/per-pr.yml
+1 −0 .gitignore
+73 −0 AGENTS.md
+9 −5 client/src/lib.rs
+15 −16 client/src/metrics.rs
+2 −2 client/src/proxy.rs
+8 −7 client/src/raw.rs
+77 −15 client/src/retry.rs
+4 −4 client/src/worker_registry/mod.rs
+1 −1 client/src/workflow_handle/mod.rs
+8 −0 core-api/Cargo.toml
+1,544 −0 core-api/src/envconfig.rs
+2 −0 core-api/src/lib.rs
+46 −8 core-api/src/worker.rs
+13 −3 core/Cargo.toml
+33 −4 core/src/abstractions.rs
+151 −1 core/src/core_tests/workflow_tasks.rs
+10 −3 core/src/ephemeral_server/mod.rs
+14 −14 core/src/internal_flags.rs
+4 −0 core/src/lib.rs
+37 −64 core/src/pollers/poll_buffer.rs
+3 −3 core/src/protosext/mod.rs
+6 −5 core/src/telemetry/metrics.rs
+2 −2 core/src/worker/activities.rs
+7 −7 core/src/worker/activities/activity_heartbeat_manager.rs
+14 −13 core/src/worker/activities/local_activities.rs
+48 −22 core/src/worker/client.rs
+15 −10 core/src/worker/mod.rs
+100 −73 core/src/worker/nexus.rs
+3 −2 core/src/worker/tuner/resource_based.rs
+8 −8 core/src/worker/workflow/history_update.rs
+1 −4 core/src/worker/workflow/machines/child_workflow_state_machine.rs
+112 −20 core/src/worker/workflow/machines/nexus_operation_state_machine.rs
+1 −1 core/src/worker/workflow/machines/update_state_machine.rs
+22 −29 core/src/worker/workflow/machines/workflow_machines.rs
+28 −30 core/src/worker/workflow/managed_run.rs
+191 −108 core/src/worker/workflow/mod.rs
+79 −30 core/src/worker/workflow/wft_poller.rs
+33 −33 core/src/worker/workflow/workflow_stream.rs
+20 −0 sdk-core-protos/protos/api_cloud_upstream/.github/workflows/push-to-buf.yml
+6 −0 sdk-core-protos/protos/api_cloud_upstream/CODEOWNERS
+17 −6 sdk-core-protos/protos/api_cloud_upstream/README.md
+1 −1 sdk-core-protos/protos/api_cloud_upstream/VERSION
+7 −2 sdk-core-protos/protos/api_cloud_upstream/buf.lock
+2 −0 sdk-core-protos/protos/api_cloud_upstream/buf.yaml
+78 −0 sdk-core-protos/protos/api_cloud_upstream/temporal/api/cloud/cloudservice/v1/request_response.proto
+29 −0 sdk-core-protos/protos/api_cloud_upstream/temporal/api/cloud/cloudservice/v1/service.proto
+74 −32 sdk-core-protos/protos/api_cloud_upstream/temporal/api/cloud/identity/v1/message.proto
+45 −15 sdk-core-protos/protos/api_cloud_upstream/temporal/api/cloud/namespace/v1/message.proto
+7 −1 sdk-core-protos/protos/api_cloud_upstream/temporal/api/cloud/nexus/v1/message.proto
+3 −3 sdk-core-protos/protos/api_cloud_upstream/temporal/api/cloud/operation/v1/message.proto
+3 −3 sdk-core-protos/protos/api_cloud_upstream/temporal/api/cloud/region/v1/message.proto
+16 −1 sdk-core-protos/protos/local/temporal/sdk/core/nexus/nexus.proto
+3 −3 sdk-core-protos/protos/local/temporal/sdk/core/workflow_activation/workflow_activation.proto
+3 −0 sdk-core-protos/protos/local/temporal/sdk/core/workflow_commands/workflow_commands.proto
+10 −14 sdk/src/lib.rs
+24 −24 sdk/src/workflow_context.rs
+7 −0 sdk/src/workflow_context/options.rs
+35 −19 test-utils/src/lib.rs
+86 −0 tests/cloud_tests.rs
+23 −26 tests/fuzzy_workflow.rs
+2 −2 tests/integ_tests/metrics_tests.rs
+94 −8 tests/integ_tests/polling_tests.rs
+45 −2 tests/integ_tests/worker_tests.rs
+3 −3 tests/integ_tests/worker_versioning_tests.rs
+3 −55 tests/integ_tests/workflow_tests.rs
+1 −1 tests/integ_tests/workflow_tests/local_activities.rs
+275 −10 tests/integ_tests/workflow_tests/nexus.rs
+2 −51 tests/main.rs
+13 −1 tests/runner.rs
4 changes: 2 additions & 2 deletions packages/test/src/test-bridge.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ const GenericConfigs = {
tuner: {
workflowTaskSlotSupplier: {
type: 'fixed-size',
numSlots: 1,
numSlots: 2,
},
activityTaskSlotSupplier: {
type: 'fixed-size',
Expand All @@ -280,7 +280,7 @@ const GenericConfigs = {
nonStickyToStickyPollRatio: 0.5,
workflowTaskPollerBehavior: {
type: 'simple-maximum',
maximum: 1,
maximum: 2,
},
activityTaskPollerBehavior: {
type: 'autoscaling',
Expand Down
4 changes: 2 additions & 2 deletions packages/workflow/src/interfaces.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@ export interface ContinueAsNewOptions {
* @deprecated In favor of the new Worker Deployment API.
* @experimental The Worker Versioning API is still being designed. Major changes are expected.
*/
versioningIntent?: VersioningIntent;
versioningIntent?: VersioningIntent; // eslint-disable-line deprecation/deprecation
}

/**
Expand Down Expand Up @@ -496,7 +496,7 @@ export interface ChildWorkflowOptions extends Omit<CommonWorkflowOptions, 'workf
* @deprecated In favor of the new Worker Deployment API.
* @experimental The Worker Versioning API is still being designed. Major changes are expected.
*/
versioningIntent?: VersioningIntent;
versioningIntent?: VersioningIntent; // eslint-disable-line deprecation/deprecation
}

export type RequiredChildWorkflowOptions = Required<Pick<ChildWorkflowOptions, 'workflowId' | 'cancellationType'>> & {
Expand Down
2 changes: 1 addition & 1 deletion packages/workflow/src/workflow.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ function scheduleActivityNextHandler({ options, args, headers, seq, activityType
headers,
cancellationType: encodeActivityCancellationType(options.cancellationType),
doNotEagerlyExecute: !(options.allowEagerDispatch ?? true),
versioningIntent: versioningIntentToProto(options.versioningIntent),
versioningIntent: versioningIntentToProto(options.versioningIntent), // eslint-disable-line deprecation/deprecation
priority: options.priority ? compilePriority(options.priority) : undefined,
},
});
Expand Down
Loading