Skip to content

MUSL support #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2025
Merged

MUSL support #216

merged 1 commit into from
Feb 6, 2025

Conversation

cretz
Copy link
Member

@cretz cretz commented Feb 6, 2025

What was changed

Checklist

  1. Closes [Feature Request] Build musl gem #215

@cretz cretz force-pushed the musl branch 5 times, most recently from 1dcb4a9 to b903029 Compare February 6, 2025 18:03
@cretz cretz requested a review from a team February 6, 2025 18:59
@cretz cretz marked this pull request as ready for review February 6, 2025 18:59
@@ -94,7 +98,12 @@ jobs:
rubyPlatform: x86_64-darwin
- os: macos-latest
rubyPlatform: arm64-darwin
- os: ubuntu-latest
rubyVersion: "3.3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's saying you will no longer run this for Ruby 3.3 on non-musl. Is this really what you meant?

Copy link
Member Author

@cretz cretz Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This actually adds a new single entry to the matrix due to the field below this one for setting a container different than an existing metric. It does not affect existing ones. See https://github.com/temporalio/sdk-ruby/actions/runs/13185031590. In fact, since we install Ruby a different way for Alpine, technically I could set this to any value because it is not used for this specific matrix entry.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

due to the field below this one for setting a container different than an existing metric

Oh, right… very subtle. I'd suggest a comment.

@cretz cretz merged commit c32e808 into temporalio:main Feb 6, 2025
6 checks passed
@cretz cretz deleted the musl branch February 6, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Build musl gem
2 participants