Fix more type errors

[dandavison]

Miscellaneous type error fixes, making progress towards fixing them all, opening PR for this subset since this is how many got done right now and we don't want them to pick up conflicts.

Reviewers: the commit named "interesting" contains slightly more interesting fixes.

[cretz]

Nothing blocking

[cretz]

This is interesting. Is re-inheriting ABC at every level a general Python preference or just a preference of a certain tool?

[dandavison]

Pyright was telling us to do it since they were effectively still ABCs

https://docs.basedpyright.com/v1.31.0/configuration/config-files/#reportImplicitAbstractClass

We can disable any we don't like, but I was thinking that we should err on the side of going with them.

[dandavison]

Hm, actually that's basedpyright-specific. I'm going to revert it.

[cretz]

What is the harm in using the constructor form of the TypedDict here instead of the dict literal with string literals?

[dandavison]

I couldn't see how to make it work with pyright (and your comment already indicated mypy probelems)

$ uv run pyright
/Users/dan/src/temporalio/sdk-python/temporalio/contrib/opentelemetry.py
  /Users/dan/src/temporalio/sdk-python/temporalio/contrib/opentelemetry.py:130:15 - error: Argument of type "object" cannot be assigned to parameter "kwargs" of type "(...) -> Unknown" in function "update"
    Type "object" is not assignable to type "(...) -> Unknown" (reportArgumentType)

[cretz]

Yeah, unfortunate that we can't use that nice constructor-like kwarg approach afforded to us by typed dicts

[cursor]

Bug: Test Validation Silently Ignores Unexpected Errors

The test validation function no longer fails on unexpected type errors. A removed loop previously ensured tests failed if any type errors occurred beyond those explicitly expected via assertion comments. Now, such unexpected errors are silently ignored, reducing test strictness and potentially masking new type issues or regressions.

tests/test_type_errors.py#L84-L90

sdk-python/tests/test_type_errors.py

Lines 84 to 90 in 3c8c009

	)
	def _has_type_error_assertions(test_file: Path) -> bool:
	"""Check if a file contains any type error assertions."""
	with open(test_file) as f:
	return any(re.search(r"# assert-type-error-\w+:", line) for line in f)

Fix in Cursor • Fix in Web

---

Was this report helpful? Give feedback by reacting with 👍 or 👎

[dandavison]

Bug: Test Validation Silently Ignores Unexpected Errors

The test validation function no longer fails on unexpected type errors. A removed loop previously ensured tests failed if any type errors occurred beyond those explicitly expected via assertion comments. Now, such unexpected errors are silently ignored, reducing test strictness and potentially masking new type issues or regressions.

I removed this assertion because it was failing on type: ignored code. It wasn't appropriate to make those drive-by assertions in the course of checking the type error assertions. Checking for type errors in general is done by the type checkers which, unlike the type error test, are running with the type: ignores enabled.