Skip to content

Set supported pyright diagnostics explicitly in pyproject.toml #954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2025

Conversation

dandavison
Copy link
Contributor

@dandavison dandavison commented Jul 10, 2025

A change of this sort (modulo the exact set of exclusions we make) is essentially forced on us by Cursor's switch to https://github.com/DetachHead/basedpyright, which AFAIK defaults to reporting every type checking error category. The set added here are ones that I've found to be essential given the current state and conventions in our codebase.

However, I think that this is a good direction, independently of Cursor: by explicitly specifying the subset of Pyright diagnostics that we support, we should be able to get to the position where the type-checking requirements made by our CI exactly match those made by our IDE.

@dandavison dandavison requested a review from a team as a code owner July 10, 2025 16:04
@dandavison dandavison merged commit bdddb07 into main Jul 10, 2025
16 checks passed
@dandavison dandavison deleted the pyright branch July 10, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants