Set supported pyright diagnostics explicitly in pyproject.toml #954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change of this sort (modulo the exact set of exclusions we make) is essentially forced on us by Cursor's switch to https://github.com/DetachHead/basedpyright, which AFAIK defaults to reporting every type checking error category. The set added here are ones that I've found to be essential given the current state and conventions in our codebase.
However, I think that this is a good direction, independently of Cursor: by explicitly specifying the subset of Pyright diagnostics that we support, we should be able to get to the position where the type-checking requirements made by our CI exactly match those made by our IDE.