💥 Streamline OpenAI module layout #947
Merged
+359
−364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
reviewed
Jul 8, 2025
|
Let's also make sure to put a big 💥 on this PR as breaking compatibility. Doesn't have to be on PR title, can just be in description, we just need to make sure we call it out in next release notes. |
tconley1428
changed the title
cretz
approved these changes
Jul 8, 2025
Comment on lines
+17
to
+18
| TestModel, | ||
| TestModelProvider, |
There was a problem hiding this comment.
This is a bit more than "streamline OpenAI module layout", this gets into testing approach. We can leave in this PR since it's all alpha/experimental anyways, but would like to have a discussion on ideas/approaches for a test harness here (which may end up looking similar).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Consolidated exposed objects from the openai agents module.
Why?
Easier use
Checklist
Closes
How was this tested:
Existing tests
Any docs updates needed?
OpenAI readme and samples will need to be updated.