Skip to content

Adding encoding of payload headers, currently defaults to existing behavior, not encoding #939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jul 8, 2025
Merged

Adding encoding of payload headers, currently defaults to existing behavior, not encoding #939

merged 13 commits into from
Jul 8, 2025
+342 −12

Conversation

tconley1428
Copy link
Contributor

What was changed

Support for encoding/decoding headers across client/activity/workflow.

Why?

Checklist

  1. Closes [Feature Request] Opt-in support for applying codec to headers #925

  2. How was this tested:

  1. Any docs updates needed?

@tconley1428 tconley1428 requested a review from a team as a code owner July 3, 2025 17:46
cretz
cretz reviewed Jul 7, 2025
View reviewed changes
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to see if we can get some user feedback about the danger in changing the default for applying header codecs

cretz
cretz reviewed Jul 7, 2025
View reviewed changes
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor things. Also let's change the title of the PR so it doesn't look like we're enabling this by default

@tconley1428 tconley1428 changed the title Adding encoding of payload headers, currently defaults to true Adding encoding of payload headers, currently defaults to existing behavior, not encoding Jul 7, 2025
cretz
cretz approved these changes Jul 8, 2025
View reviewed changes
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor, non-blocking suggestion.

@tconley1428 tconley1428 merged commit e17146f into main Jul 8, 2025
27 of 28 checks passed
@tconley1428 tconley1428 deleted the header_encoding branch July 8, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cretz cretz cretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Opt-in support for applying codec to headers
2 participants
@tconley1428 @cretz