Fixed serialization of typing.Literal
#867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
May 14, 2025
| @@ -23,6 +23,7 @@ | |||
| ClassVar, | |||
| Dict, | |||
| List, | |||
| Literal, | |||
There was a problem hiding this comment.
Confirmed that typing.Literal is present in 3.8+ so it is safe for use in all versions we currently support (it wasn't present in the oldest supported Python version when we first developed this)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Fixed the converter so that both
typing.Literalandtyping_extensions.Literaltype hints are handled correctly. Previously onlytyping_extensions.Literalworked as expected.Checklist
Closes [Bug] Serializing Literal fails #852
How was this tested:
tests/test_converter.py::test_json_type_hintswas updated with new checks.No