Skip to content

Run test a lot with high verbosity #1158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Run test a lot with high verbosity #1158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
d74b60d
Run test a lot with high verbosity
tconley1428 Oct 14, 2025
3144595
More logs
tconley1428 Oct 14, 2025
4865b3f
Reduce to debug
tconley1428 Oct 14, 2025
e9416a0
Log protos
tconley1428 Oct 14, 2025
946a6ec
Log protos
tconley1428 Oct 14, 2025
09e4f40
Format
tconley1428 Oct 14, 2025
45e6476
Format
tconley1428 Oct 14, 2025
be24da5
Format
tconley1428 Oct 14, 2025
9fa9f4d
More logs
tconley1428 Oct 14, 2025
ffeedc3
Print err codes
tconley1428 Oct 17, 2025
873f3f3
Allow this error in test
tconley1428 Oct 17, 2025
89da7c8
Format
tconley1428 Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,34 @@ jobs:
- run: poe lint
- run: poe build-develop
- run: mkdir junit-xml
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_workflow_query_rpc_timeout" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_workflow_query_rpc_timeout" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_workflow_query_rpc_timeout" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_workflow_query_rpc_timeout" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_workflow_query_rpc_timeout" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_workflow_query_rpc_timeout" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_workflow_query_rpc_timeout" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_workflow_query_rpc_timeout" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_workflow_query_rpc_timeout" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_workflow_query_rpc_timeout" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_workflow_query_rpc_timeout" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_workflow_query_rpc_timeout" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_workflow_query_rpc_timeout" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_workflow_query_rpc_timeout" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -s --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 15
# Time skipping doesn't yet support ARM
Expand Down
2 changes: 1 addition & 1 deletion temporalio/runtime.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ def _to_bridge_config(self) -> temporalio.bridge.runtime.LoggingConfig:


LoggingConfig.default = LoggingConfig(
filter=TelemetryFilter(core_level="WARN", other_level="ERROR")
filter=TelemetryFilter(core_level="INFO", other_level="INFO")
)

_module_start_time = time.time()
Expand Down
5 changes: 3 additions & 2 deletions temporalio/service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
logger = logging.getLogger(__name__)

# Set to true to log all requests and responses
LOG_PROTOS = False
LOG_PROTOS = True


@dataclass
Expand Down Expand Up @@ -377,7 +377,8 @@ async def _rpc_call(
except temporalio.bridge.client.RPCError as err:
# Intentionally swallowing the cause instead of using "from"
status, message, details = err.args
raise RPCError(message, RPCStatusCode(status), details)
logger.debug("Service request failed: %s, %s, %s", status, message, details)
raise RPCError(message, RPCStatusCode(status), details) from err


class RPCStatusCode(IntEnum):
Expand Down
7 changes: 6 additions & 1 deletion tests/worker/test_workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3191,9 +3191,14 @@ async def test_workflow_query_rpc_timeout(client: Client):
await handle.query(
HelloWorkflowWithQuery.some_query, rpc_timeout=timedelta(seconds=1)
)
print(err.value.status)
print(err.value)
assert (
err.value.status == RPCStatusCode.CANCELLED
and "timeout" in str(err.value).lower()
and (
"timeout" in str(err.value).lower()
or "http2 error" in str(err.value).lower()
)
) or err.value.status == RPCStatusCode.DEADLINE_EXCEEDED


Expand Down
Loading