Add support for parameterized and generic types in DataConverter (#2413) #2605
+145
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, I think this makes sense. Can we add a test to verify the reported issue is now resolved? I think we just need to have a workflow with the following signature |
| * @return the raw Class for the type | ||
| */ | ||
| static Class<?> getRawClass(Type type) { | ||
| if (type instanceof Class) { |
There was a problem hiding this comment.
Do we need to handle any other type? I might just need to test but isn't GenericArrayType possible as well?
There was a problem hiding this comment.
Good catch regarding GenericArrayType - I've added support for that as well now.
|
@Quinn-With-Two-Ns added specific test you mentioned to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal to resolve #2413