Nexus release seemed to forget to AddNexusService in extensions #535
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Support AddNexusService same as other worker
Add
calls for convenience.Why?
Because digging into
ConfigureOptions
isn't as obvious and we already expose AddX calls in other places. This makes things consistent.The Extensions project README.md was updated to use
AddNexusService
.Concerns
Ideally, we could use the service provider to register these services instead of forcing ctor while registering...something like:
I couldn't see a clear way to do this without the terrible pattern:
Any other ideas we can try to make this more container friendly?