Fixed memory corruption issues in CustomSlotSupplier #532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
reviewed
Oct 2, 2025
cretz
reviewed
Oct 2, 2025
cretz
reviewed
Oct 6, 2025
cretz
approved these changes
Oct 7, 2025
maciejdudko
force-pushed
the
bridge-custom-slot-supplier-rework
branch
from
51fff70 to
6708a09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
temporalio/sdk-core#1025 changes the design of custom slot supplier in C bridge to fix memory corruption issues. This PR adapts SDK code to these changes.
Why?
Fixes memory corruption bug.
Checklist
Closes [Bug] Issues with ReserveCtxFromBridge #458
How was this tested:
There is no test for the original bug. Due to the nature of this bug, it's impossible to write a test that reliably triggers the problematic conditions. The fix can be verified over time by the lack of transient CI failures caused by this bug.
General functionality of the custom slot supplier is tested by pre-existing tests.