Fix issue with search attribute keyword list type #529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciejdudko
approved these changes
Sep 25, 2025
Comment on lines
+44
to
50
| internal SearchAttributeCollection() | ||
| : this(new()) | ||
| { | ||
| } | ||
|
|
||
| private SearchAttributeCollection(SortedDictionary<SearchAttributeKey, object> values) => | ||
| this.values = values; |
There was a problem hiding this comment.
Nit: the private constructor is only used once, in the internal constructor. It can be removed and initialization can be done directly in the internal constructor (or even better, inline in the field declaration).
There was a problem hiding this comment.
This private constructor is also used in FromProto and ToSearchAttributeCollection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
List<string>Checklist