Skip to content

Fix cloud CI run and minor doc fix #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2024
Merged

Fix cloud CI run and minor doc fix #339

merged 1 commit into from
Aug 30, 2024

Conversation

cretz
Copy link
Member

@cretz cretz commented Aug 29, 2024

What was changed

  • Fixed env vars used for cloud CI tests to properly test cloud
  • Fixed copy pasta on RPC options API docs

Checklist

  1. Closes [Bug] Copy paste error in Update docstring / API reference documentation #331
  2. Closes [Bug] Cloud tests not actually running on cloud #333

@cretz cretz requested a review from a team August 30, 2024 14:56
@cretz cretz marked this pull request as ready for review August 30, 2024 14:56
@cretz cretz merged commit 622eda1 into main Aug 30, 2024
7 checks passed
@cretz cretz deleted the fix-cloud-ci branch August 30, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dandavison dandavison dandavison approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] Cloud tests not actually running on cloud [Bug] Copy paste error in Update docstring / API reference documentation

2 participants

@cretz @dandavison