Call tfw_http_hdr_split only during hpack encoding #2367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvgeniiMekhanik
force-pushed
the
MekhanikEvgenii/1411-4
branch
3 times, most recently
from
5b32e0f to
ff1149a
Compare
EvgeniiMekhanik
changed the title
EvgeniiMekhanik
force-pushed
the
MekhanikEvgenii/1411-4
branch
from
ff1149a to
8115185
Compare
EvgeniiMekhanik
force-pushed
the
MekhanikEvgenii/1411-4
branch
from
8115185 to
db78e5c
Compare
EvgeniiMekhanik
force-pushed
the
MekhanikEvgenii/1411-4
branch
from
db78e5c to
4629b3b
Compare
const-t
requested changes
Mar 21, 2025
EvgeniiMekhanik
force-pushed
the
MekhanikEvgenii/1411-4
branch
from
cd90a87 to
9498803
Compare
krizhanovsky
approved these changes
Apr 5, 2025
There was a problem hiding this comment.
LGTM. But please edit #1411 and explicitly link the PR to the bullet, which is fixed now
EvgeniiMekhanik
force-pushed
the
MekhanikEvgenii/1411-4
branch
from
9498803 to
b36a343
Compare
Previously we call `tfw_http_hdr_split` twice - in `tfw_hpack_encoder_index` and in `tfw_hpack_hdr_add`, this patch fixes this behaviour, we split header at the beginning of `__tfw_hpack_encode` if it is necessary and use header name and header value later.
- Remove garbage - Change macros to `static inline` function. - We should not change return code of `tfw_hpack_encoder_index` beacuse if we can't add new header to the table we just not set HPACK_IDX_FLAG_ADD to result. But we don't need to check that return code of `tfw_hpack_encoder_index` is greater or equal to zero because it is always true.
EvgeniiMekhanik
force-pushed
the
MekhanikEvgenii/1411-4
branch
from
b36a343 to
42e3c11
Compare
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.