Add basic h2 proto tests #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run h2spec utility against Tempesta and evaluate return code. Increase debug level to get h2spec detailed results. A new directive in `tests_config.ini` under section `[Client]` may be required since h2spec is never available through pacage manager and need to be installed from https://github.com/summerwind/h2spec : h2spec = /path/to/h2spec Fix tempesta-tech/tempesta#739
krizhanovsky
approved these changes
Mar 12, 2020
| __author__ = 'Tempesta Technologies, Inc.' | ||
| __copyright__ = 'Copyright (C) 2020 Tempesta Technologies, Inc.' | ||
| __license__ = 'GPL2' | ||
|
|
There was a problem hiding this comment.
Please add a comment what's the new class is for.
| { | ||
| 'id' : 'h2spec', | ||
| 'type' : 'external', | ||
| 'binary' : 'h2spec', |
There was a problem hiding this comment.
Please add h2spec to requirements in Readme.md . Also maybe update tests_config.ini.sample as well that we'll have the test by default?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run h2spec utility against Tempesta and evaluate return code. Increase
debug level to get h2spec detailed results.
A new directive in
tests_config.iniunder section[Client]may berequired since h2spec is never available through pacage manager and
need to be installed from https://github.com/summerwind/h2spec :
Fix tempesta-tech/tempesta#739