-
Notifications
You must be signed in to change notification settings - Fork 6
Initial TLS 1.2 handshake test #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We use OpenSSL for the tests and modern OpenSSL versions don't support SSLv{1,2,3}.0, so use TLSv1.{0,1} just to test that we correctly drop wrong TLS connections. We do not support SSL as well and any SSL record is treated as a broken TLS record, so fuzzing of normal TLS fields should be used to test TLS fields processing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, the only real issue I've seen - attempts to directly use of the TLS certificate while it's not available if the framework and the Tempesta are started on different VMs.
transparrently generates certificates for HTTPS Tempesta configurations. Fix pure local Tempesta configuration - copy configuration and certificate files to remote node.
TlsDuplicateCerts.test_duplicate - vhost successfully loads 2 similar cerificates, but must not successfully communicate with a client. TlsDuplicateCerts.test_2_diff_certs - vhost successfully loads 2 different cerificates and must successfully communicate with a client. TlsVhostHandshakeTest - Tempesta routes requests according to SNI and send correct certficiates for each vhost. TlsCertReconfig - Tempesta reloads certificate without douwntime. Many cleanups and small infrastucture extensions.
Add tests for empty SNI, bad sinature algorithms and elliptic curves.
Test many ciphersuites.
with it, so replace Exception with our native Error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There are some comments, mostly spelling, below.
The issue tempesta-tech/tempesta#737 is fully done (yahoo!!). Some tests may not work because of unfixed issues - I'll disable them before the merge.