feat: improve how to use resource_group in modules

[posquit0]

Summary

Update resource group configuration to use object-based pattern.

Changes

• Update module version from ~> 0.10.0 to ~> 0.12.0
• Replace individual resource_group_* variables with single object variable
• Update all references to use var.resource_group.* structure
• Add resource_group output to each module

Modules Updated

• instance
• placement-group
• ssh-key

Test Plan

• Review variable changes
• Verify resource-group module references are correct
• Check outputs are properly formatted

[gemini-code-assist]

Summary of Changes

Hello @posquit0, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the way resource group configurations are managed within several Terraform modules. By transitioning from disparate individual variables to a unified object structure, it enhances the clarity and maintainability of module inputs. This change streamlines the configuration process for resource groups and ensures a more consistent approach across the affected modules.

Highlights

• Resource Group Configuration Refactor: Consolidated multiple individual resource_group_* variables into a single, object-based resource_group variable for improved modularity and consistency.
• Module Version Update: Upgraded the tedilabs/misc/aws//modules/resource-group module dependency from ~> 0.10.0 to ~> 0.12.0.
• Output Addition: Introduced a new resource_group output to each affected module (instance, placement-group, ssh-key) to expose details of the managed resource group.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively refactors the resource group configuration across the instance, placement-group, and ssh-key modules by consolidating multiple variables into a single object. This is a great improvement for maintainability and consistency. The module versions have been updated, and new outputs for the resource group have been added as described. My review found a couple of minor documentation issues in the variable descriptions, which appear to be copy-paste errors. Otherwise, the changes are well-implemented.

[gemini-code-assist]

The description for the name attribute within the resource_group variable appears to be copied from another module. It incorrectly refers to 'instance name'. For clarity and accuracy, it should refer to 'placement group name'.

  description = <<EOF
  (Optional) A configurations of Resource Group for this module. `resource_group` as defined below.
    (Optional) `enabled` - Whether to create Resource Group to find and group AWS resources which are created by this module. Defaults to `true`.
    (Optional) `name` - The name of Resource Group. A Resource Group name can have a maximum of 127 characters, including letters, numbers, hyphens, dots, and underscores. The name cannot start with `AWS` or `aws`. If not provided, a name will be generated using the module name and placement group name.
    (Optional) `description` - The description of Resource Group. Defaults to `Managed by Terraform.`.
  EOF

[gemini-code-assist]

The description for the name attribute within the resource_group variable appears to be copied from another module. It incorrectly refers to 'instance name'. For clarity and accuracy, it should refer to 'SSH key name'.

  description = <<EOF
  (Optional) A configurations of Resource Group for this module. `resource_group` as defined below.
    (Optional) `enabled` - Whether to create Resource Group to find and group AWS resources which are created by this module. Defaults to `true`.
    (Optional) `name` - The name of Resource Group. A Resource Group name can have a maximum of 127 characters, including letters, numbers, hyphens, dots, and underscores. The name cannot start with `AWS` or `aws`. If not provided, a name will be generated using the module name and SSH key name.
    (Optional) `description` - The description of Resource Group. Defaults to `Managed by Terraform.`.
  EOF