Skip to content

Conversation

philprime
Copy link
Member

@philprime philprime commented Sep 2, 2025

This pull request introduces significant improvements to the CI build and code signing process for the iOS project, with changes to the GitHub Actions workflow, Xcode project configuration, and Fastlane setup. The main goals are to make code signing fully manual and more CI-friendly, and to enhance integration with Sentry for build artifact analysis.

CI/CD workflow and build process:

  • Updated the GitHub Actions workflow in .github/workflows/build-test.yml to use Fastlane for building (bundle exec fastlane build_ci) and set up Ruby with bundler caching. Also, improved concurrency grouping to include the job name for more granular control. [1] [2]

Code signing configuration:

  • Changed code signing style from Automatic to Manual for all targets in Flinky.xcodeproj/project.pbxproj, removed the DEVELOPMENT_TEAM value, and added empty PROVISIONING_PROFILE_SPECIFIER fields to support manual signing in CI environments. Also, updated code sign identity to "iPhone Distribution" for the main app target. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]

Fastlane enhancements:

  • Improved the build_ci lane in fastlane/Fastfile to configure CI keychain and set match to readonly for non-interactive builds, and added Sentry build upload steps to automate artifact analysis in CI. [1] [2]
  • Added Sentry build upload to the release lane for xcarchive analysis and commit association.

Plugin management:

  • Updated fastlane/Pluginfile to use the latest fastlane-plugin-sentry directly from the official GitHub repository for improved compatibility and bug fixes.

@Copilot Copilot AI review requested due to automatic review settings September 2, 2025 13:38
@philprime philprime force-pushed the feature/sentry-mobile-app-upload branch 2 times, most recently from 50007ff to d8832c4 Compare September 2, 2025 13:40
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds Sentry mobile app upload functionality to the beta lane and updates the Sentry plugin configuration. The changes integrate mobile app archive uploading to Sentry for crash analysis and debugging purposes.

  • Updates Sentry plugin to use a specific Git branch with mobile upload support
  • Adds sentry_upload_mobile_app action to the beta lane workflow
  • Modifies build configuration to generate xcarchive files for Sentry upload

Reviewed Changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated 4 comments.

File Description
fastlane/Pluginfile Updates Sentry plugin to use Git branch with mobile upload functionality
fastlane/Fastfile Adds mobile app upload to Sentry and configures build to generate xcarchive
Comments suppressed due to low confidence (1)

fastlane/Fastfile:1

  • Trailing comma after the last parameter in the function call. This will cause a syntax error in Ruby.
default_platform(:ios)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@philprime philprime force-pushed the feature/sentry-mobile-app-upload branch from e8b0edb to fcdd8e2 Compare September 2, 2025 14:55
- Added support for the `sentry-fastlane-plugin` from the GitHub repository.
- Updated various gems in the Gemfile.lock to their latest versions.
- Modified the build-test workflow to include Ruby setup and use Fastlane for CI builds.
- Adjusted code signing settings in the Xcode project to Manual and cleared the development team ID for better configuration management.
- Included xcarchive files in .gitignore to prevent unnecessary tracking.
@philprime philprime force-pushed the feature/sentry-mobile-app-upload branch from 157c18f to cc954c4 Compare September 14, 2025 19:05
@philprime philprime merged commit cda28ea into main Sep 14, 2025
2 of 3 checks passed
@philprime philprime deleted the feature/sentry-mobile-app-upload branch September 14, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant