Skip to content

Conversation

philprime
Copy link
Member

@philprime philprime commented Sep 1, 2025

This pull request updates the CI workflow in .github/workflows/build-test.yml to optimize build artifact handling and clarify job naming. The main improvements focus on caching Xcode Derived Data between jobs and renaming jobs for consistency.

CI workflow improvements:

  • Added a step in the build job to upload Xcode Derived Data as an artifact, enabling reuse in subsequent jobs and speeding up builds.
  • Updated the test and test-ui jobs to download the Derived Data artifact before running tests, ensuring they use the cached build output. [1] [2]

Job naming and dependencies:

  • Renamed build-test to test and build-test-ui to test-ui for clearer job names. [1] [2]
  • Set both test and test-ui jobs to depend on the build job, ensuring build artifacts are available before testing. [1] [2]

@Copilot Copilot AI review requested due to automatic review settings September 1, 2025 12:54
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR restructures the CI workflow to optimize build processes by separating build and test jobs and implementing artifact sharing for Xcode derived data.

  • Splits the combined build-test jobs into separate build and test jobs
  • Adds derived data artifact upload/download to share build outputs between jobs
  • Creates dependency chain where test jobs depend on the build job completion

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +41 to +42
path: |
~/Library/Developer/Xcode/DerivedData
Copy link

Copilot AI Sep 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The path uses a tilde (~) which may not expand correctly in GitHub Actions. Consider using an absolute path or the $HOME environment variable instead: $HOME/Library/Developer/Xcode/DerivedData.

Copilot uses AI. Check for mistakes.

uses: actions/download-artifact@v4
with:
name: derived-data
path: ~/Library/Developer/Xcode/DerivedData
Copy link

Copilot AI Sep 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The path uses a tilde (~) which may not expand correctly in GitHub Actions. Consider using an absolute path or the $HOME environment variable instead: $HOME/Library/Developer/Xcode/DerivedData.

Copilot uses AI. Check for mistakes.

uses: actions/download-artifact@v4
with:
name: derived-data
path: ~/Library/Developer/Xcode/DerivedData
Copy link

Copilot AI Sep 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The path uses a tilde (~) which may not expand correctly in GitHub Actions. Consider using an absolute path or the $HOME environment variable instead: $HOME/Library/Developer/Xcode/DerivedData.

Copilot uses AI. Check for mistakes.

@philprime
Copy link
Member Author

Closing this because caching derived data invalidates signatures of frameworks (like Sentry.xcframework)

@philprime philprime closed this Sep 1, 2025
@philprime philprime deleted the feature/ci-share-derived-data branch September 1, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant