fix(wiki): improve security and remove unused interface #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChildProcessError was introduced previously in testing; however was not finished.
virgofx
force-pushed
the
wiki-updates-10-10
branch
9 times, most recently
from
5cd9732 to
7e9bb38
Compare
Migrate where possible from execSync() to execFileSync() and move the dynamic directories (even though they are properly resolved) into arguments such that they don't go through the shell glob expansion. fixes #8
virgofx
force-pushed
the
wiki-updates-10-10
branch
from
36cd6ca to
15f8efb
Compare
Release PlanNo terraform modules updated in this pull request.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused ChildProcessError interface and improve wiki security by switching to execFileSync() and avoiding dynamic shell args.
Changes:
execSync()withexecFileSync()in wiki functionalityexecFileSync()instead of including them in the shell commandRelated Issues:
Fixes #8