feat: add GHES compatibility, update terraform-docs to v0.20.0, and improve utility functions #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virgofx
force-pushed
the
202-support-github-enterprise-server-with-custom-gh-api-base-urls
branch
3 times, most recently
from
d15acfe to
1057fdd
Compare
virgofx
force-pushed
the
202-support-github-enterprise-server-with-custom-gh-api-base-urls
branch
2 times, most recently
from
e87db55 to
b966252
Compare
virgofx
changed the title
virgofx
force-pushed
the
202-support-github-enterprise-server-with-custom-gh-api-base-urls
branch
14 times, most recently
from
56051c8 to
e200b68
Compare
virgofx
changed the title
virgofx
force-pushed
the
202-support-github-enterprise-server-with-custom-gh-api-base-urls
branch
2 times, most recently
from
e4adf29 to
84018fe
Compare
virgofx
force-pushed
the
202-support-github-enterprise-server-with-custom-gh-api-base-urls
branch
4 times, most recently
from
6943b69 to
ca666ad
Compare
virgofx
added
documentation
There was a problem hiding this comment.
Pull Request Overview
This pull request enhances GHES compatibility, updates dependency versions (including terraform-docs v0.20.0), and modernizes utility functions and documentation. Key changes include updates to branding and templating in constants and README, refactoring of utility functions (e.g. replacing removeTrailingDots with removeTrailingCharacters), and comprehensive adjustments to tests and release comment logic.
Reviewed Changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/utils/file.ts | Minor cleanup by removing commented-out code |
| src/utils/constants.ts | Updated branding HTML for better GitHub/GHES presentation |
| src/terraform-module.ts | Replaced deprecated removeTrailingDots and added initial release logic |
| src/pull-request.ts | Refined PR comment content and formatting adjustments |
| src/main.ts | Enhanced changelog generation commentary |
| src/context.ts | Added API URL support and improved logging |
| package.json | Upgraded dependency versions and added new scripts |
| action.yml | Updated terraform-docs default version |
| tests/utils/string.test.ts | Adjusted tests for deprecation and new utility functions |
| tests/pull-request.test.ts | Expanded tests for release plan comments and module removal scenarios |
| ... (other test and config files) | Consistent updates across tests, mocks, and documentation |
- Add proper handling for GHES custom API endpoints via environment variables - Enhance initializeContext to include API URL detection for GHES environments - Improve wiki checkout process for GHES custom domain configurations - Update formatModuleSource to handle SSH and HTTPS conversions for GHES URLs - Fix automated tag cleanup logic to work with GHES repositories - Add changelog sections to PR comments with GHES compatibility - Update tests to support GHES functionality and edge cases - Add comprehensive documentation for GHES configuration and usage - Small tweaks to improve branding clarity on mobile
virgofx
force-pushed
the
202-support-github-enterprise-server-with-custom-gh-api-base-urls
branch
from
ca666ad to
2bbd9c2
Compare
Release Plan
Changelog
|
|
virgofx
deleted the
202-support-github-enterprise-server-with-custom-gh-api-base-urls
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces comprehensive improvements across documentation, configuration, testing, and utility functions, with a primary focus on enhancing GitHub Enterprise Server (GHES) compatibility and modernizing dependencies.
🚀 Key Features
GHES Compatibility Enhancements
Dependency Updates
terraformDocsVersionfrom previous version tov0.20.0for improved Terraform documentation generation📝 Documentation Improvements
🧪 Testing Enhancements
Expanded Test Coverage
🛠️ Utility Function Improvements
String Utilities Refactor
removeTrailingDotsfunctionremoveTrailingCharactersfor flexible trailing character removal📊 Impact Summary