⬆️ update Python version support to include 3.13 and drop 3.8 support #135
Conversation
WalkthroughThe changes update the project’s Python version support by replacing configurations based on Python 3.8 with those for Python 3.13. The CI workflow file and tox settings have been modified to remove Python 3.8 references and integrate Python 3.13, including updated database configurations and environment mappings. The documentation and tooling configuration files (CONTRIBUTING.md and pyproject.toml) have been updated to reflect the new support, with the minimum Python requirement raised from 3.8 to 3.9 and relevant classifiers adjusted. Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
techouse
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
.github/workflows/test.yml(15 hunks)CONTRIBUTING.md(2 hunks)pyproject.toml(4 hunks)tox.ini(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (20)
- GitHub Check: Test (python3.10, mysql:8.4, 0, true, 3.10)
- GitHub Check: Test (python3.10, mysql:8.0, 0, false, 3.10)
- GitHub Check: Test (python3.10, mysql:5.7, 0, false, 3.10)
- GitHub Check: Test (python3.10, mysql:5.6, 1, false, 3.10)
- GitHub Check: Test (python3.10, mysql:5.5, 1, false, 3.10)
- GitHub Check: Test (python3.10, mariadb:11.4, 0, false, 3.10)
- GitHub Check: Test (python3.11, mariadb:10.11, 0, false, 3.11)
- GitHub Check: Test (python3.10, mariadb:10.11, 0, false, 3.10)
- GitHub Check: Test (python3.10, mariadb:10.6, 0, false, 3.10)
- GitHub Check: Test (python3.10, mariadb:10.5, 0, false, 3.10)
- GitHub Check: Test (python3.10, mariadb:10.4, 0, false, 3.10)
- GitHub Check: Test (python3.10, mariadb:10.3, 0, false, 3.10)
- GitHub Check: Test (python3.11, mariadb:10.2, 0, false, 3.11)
- GitHub Check: Test (python3.10, mariadb:10.2, 0, false, 3.10)
- GitHub Check: Test (python3.11, mariadb:10.1, 1, false, 3.11)
- GitHub Check: Test (python3.10, mariadb:10.1, 1, false, 3.10)
- GitHub Check: Test (python3.11, mariadb:10.0, 1, false, 3.11)
- GitHub Check: Test (python3.10, mariadb:10.0, 1, false, 3.10)
- GitHub Check: Test (python3.10, mariadb:5.5, 1, false, 3.10)
- GitHub Check: Codacy Static Code Analysis
🔇 Additional comments (8)
CONTRIBUTING.md (1)
16-17: Updated Supported Python Versions.
The contribution guidelines now correctly state that the tool supports Python versions 3.9, 3.10, 3.11, 3.12, and 3.13. This change is in line with the PR objectives. Please ensure that any other references to the older Python versions are updated accordingly.tox.ini (1)
7-8: Addition of Python 3.13 to Environment List.
Theenvlistnow includespython3.13, which correctly extends the support matrix in accordance with the project’s shift away from Python 3.8..github/workflows/test.yml (2)
63-68: Comprehensive Addition of Python 3.13 for MariaDB Configurations.
The workflow now incorporates Python 3.13 across all relevant MariaDB test environments (e.g. for mariadb:5.5, 10.0, 10.1, 10.2, 10.3, 10.4, 10.5, 10.6, and 10.11). This aligned inclusion is consistent with the new Python support. Please double-check that any downstream dependencies or scripts recognise the updated Python version string correctly.Also applies to: 93-98, 123-128, 153-158, 183-188, 213-218, 243-248, 273-278, 303-308
393-398: Consistent Inclusion of Python 3.13 for MySQL Configurations.
The newly added Python 3.13 test environments for MySQL databases (including mysql:5.6, 5.7, 8.0, and 8.4) are well integrated into the testing matrix. Verify that the experimental flags and any other database-specific configurations continue to work as expected with Python 3.13.Also applies to: 423-428, 452-457, 481-487
pyproject.toml (4)
10-10: Updated Minimum Python Requirement.
Therequires-pythonfield has been updated to ">=3.9" which is fully in accordance with the removal of Python 3.8 support.
36-36: Addition of Python 3.13 Classifier.
The inclusion of"Programming Language :: Python :: 3.13"in the classifiers now ensures that the project metadata accurately reflects the supported Python versions.
81-82: Updated Black Target Versions.
Thetarget-versionlist under the[tool.black]section has been revised to include "py313" and remove "py38", which is perfectly aligned with the updated support for newer Python versions.
124-125: Updated MyPy Configuration.
Thepython_versionunder the[tool.mypy]section has been updated to "3.9", matching the new minimum Python version requirement.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #135 +/- ##
=======================================
Coverage 89.15% 89.15%
=======================================
Files 8 8
Lines 664 664
=======================================
Hits 592 592
Misses 72 72 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This pull request includes changes to update the supported Python versions and corresponding configurations in various files. The primary change is the removal of support for Python 3.8 and the addition of support for Python 3.13.
Updates to supported Python versions:
.github/workflows/test.yml: Removed configurations for Python 3.8 and added configurations for Python 3.13 across various database versions. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16]Documentation and configuration updates:
CONTRIBUTING.md: Updated the list of supported Python versions to include Python 3.13 and remove Python 3.8.pyproject.toml: Updated therequires-pythonfield, classifiers, target versions for the Black tool, and thepython_versionfor MyPy to reflect the removal of Python 3.8 and the addition of Python 3.13. [1] [2] [3] [4]tox.ini: Removed Python 3.8 from theenvlistandgh-actionssections, and added Python 3.13.