feat: add remember_me option to continue_with_login_identifier action #2267
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What:
remember_me
option to thecontinue_with_login_identifier
actionWhy:
Whilst implementing a frontend solution for Hanko, I found myself having to implement an exception for the
remember_me
action, because it should belong to thecontinue_with_login_identifier
action, right below the login identifier field.I basically have:
And the "Remember Me" option is not connected to the "Sign In" Action at all.
Implementation
I took the code from the "Remember Me" action (it's not that much) and put it into the "Continue With Login Identifier" action, with the input field only being sent as required input and checked if the cookie retention is set to "prompt".
Tests
I didn't find any test that would have to be adjusted.