Fix assert_selector support for Hash locator
#2826
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the following style of assertion fails: ```ruby assert_selector :table_row, "First Name" => "John", "Last Name" => "Doe" ``` The assertion cites that the `"First Name"` is an invalid option, signaling that it's being treated as a filter rather than a locator value: ``` ArgumentError: Invalid option(s) "First Name", should be one of :above, :below, :left_of, :right_of, :near, :text, :id, :class, :style, :visible, :obscured, :exact, :exact_text, :normalize_ws, :match, :wait, :filter_set, :focused ``` To resolve this issue, modify the private `Capybara::Node::Matchers#_set_query_session_options` to treat the last positional argument as a positional argument (rather than a pseudo keyword argument) if it's a `Hash` with any `String` keys.
seanpdoyle
commented
Sep 17, 2025
| query_args, query_options = query_args.dup, {} | ||
| # query_options = query_args.pop if query_options.empty? && query_args.last.is_a?(Hash) | ||
| query_options = query_args.pop if query_args.last.is_a?(Hash) | ||
| query_options = query_args.pop if query_args.last.is_a?(Hash) && query_args.last.keys.none?(String) |
There was a problem hiding this comment.
I'm pretty dissatisfied with this solution. Since it's related to positional-to-keyword argument coercion, I wonder if there's a more wholistic approach that could be take to resolve this. For example, this would still fail for symbol keys that aren't filter options:
assert_selector :table_row, First: "John", Last: "Doe"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the following style of assertion fails:
The assertion cites that the
"First Name"is an invalid option, signaling that it's being treated as a filter rather than a locator value:To resolve this issue, modify the private
Capybara::Node::Matchers#_set_query_session_optionsto treat the last positional argument as a positional argument (rather than a pseudo keyword argument) if it's aHashwith anyStringkeys.