Skip to content

fix: formula reset formatting when expression error #1997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2025
Merged

fix: formula reset formatting when expression error #1997

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions apps/nextjs-app/src/features/app/components/field-setting/options/FormulaOptions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,25 @@ import { TimeZoneFormatting } from '../formatting/TimeZoneFormatting';
import { UnionFormatting } from '../formatting/UnionFormatting';
import { UnionShowAs } from '../show-as/UnionShowAs';

const calculateTypedValue = (fields: IFieldInstance[], expression?: string) => {
const defaultResult = { cellValueType: CellValueType.String, isMultipleCellValue: false };
const calculateTypedValue = (
fields: IFieldInstance[],
expression?: string
): {
cellValueType: CellValueType;
isMultipleCellValue?: boolean;
hasError?: boolean;
} => {
const defaultResult = {
cellValueType: CellValueType.String,
isMultipleCellValue: false,
};

try {
return expression
? FormulaField.getParsedValueType(expression, keyBy(fields, 'id'))
: defaultResult;
} catch (e) {
return defaultResult;
return { ...defaultResult, hasError: true };
}
};

Expand All @@ -48,7 +58,11 @@ export const FormulaOptionsInner = (props: {
: '';
}, [expression, fields]);

const { cellValueType, isMultipleCellValue } = calculateTypedValue(fields, expression);
const {
cellValueType,
isMultipleCellValue,
hasError: expressionHasError,
} = calculateTypedValue(fields, expression);

const onExpressionChange = (expr: string) => {
const { cellValueType: newCellValueType } = calculateTypedValue(fields, expr);
Expand All @@ -59,7 +73,7 @@ export const FormulaOptionsInner = (props: {
? formatting.timeZone
: options.timeZone ?? Intl.DateTimeFormat().resolvedOptions().timeZone,
};
if (newCellValueType !== cellValueType) {
if (newCellValueType !== cellValueType || expressionHasError) {
const defaultFormatting = getDefaultFormatting(newCellValueType);
newOptions.formatting = defaultFormatting;
newOptions.showAs = undefined;
Expand Down