fix: remove duplicate "-simulator" when building XCFramework for iOS #3364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the Makefile, all targets (including simulators) are predefined, and the existing ifeq construct was appending an extra "-simulator" suffix to already simulator targets. As a result, identifiers like "iphoneos-simulator-simulator" were generated and the build failed.
ICEDEVILS
approved these changes
Jul 13, 2025
BoomchainLabs
approved these changes
Jul 30, 2025
davesmail1401-sudo
approved these changes
Aug 21, 2025
Turns out TDLib's patch had an issue with duplicated
When running @@ -4,10 +4,10 @@ iOS-simulator
>>> Environment variables for iphonesimulator.x86_64
SDK-iphonesimulator.x86_64: iphonesimulator
ARCH-iphonesimulator.x86_64: x86_64
-TARGET_TRIPLE-iphonesimulator.x86_64: x86_64-apple-ios-simulator-simulator
+TARGET_TRIPLE-iphonesimulator.x86_64: x86_64-apple-ios-simulator
SDK_ROOT-iphonesimulator.x86_64: /Applications/Xcode-16.0.0.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator18.0.sdk
-CC-iphonesimulator.x86_64: xcrun --sdk iphonesimulator clang -target x86_64-apple-ios-simulator-simulator
-CPP-iphonesimulator.x86_64: xcrun --sdk iphonesimulator clang -target x86_64-apple-ios-simulator-simulator -E
+CC-iphonesimulator.x86_64: xcrun --sdk iphonesimulator clang -target x86_64-apple-ios-simulator
+CPP-iphonesimulator.x86_64: xcrun --sdk iphonesimulator clang -target x86_64-apple-ios-simulator -E
CFLAGS-iphonesimulator.x86_64: -mios-simulator-version-min=12.0
LDFLAGS-iphonesimulator.x86_64: -mios-simulator-version-min=12.0
BZIP2_SRCDIR-iphonesimulator.x86_64: build/iOS-simulator/iphonesimulator.x86_64/bzip2-1.0.8
@@ -37,10 +37,10 @@ PYTHON_LIB-iphonesimulator.x86_64: td/example/ios/Py
>>> Environment variables for iphonesimulator.arm64
SDK-iphonesimulator.arm64: iphonesimulator
ARCH-iphonesimulator.arm64: arm64
-TARGET_TRIPLE-iphonesimulator.arm64: arm64-apple-ios-simulator-simulator
+TARGET_TRIPLE-iphonesimulator.arm64: arm64-apple-ios-simulator
SDK_ROOT-iphonesimulator.arm64: /Applications/Xcode-16.0.0.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator18.0.sdk
-CC-iphonesimulator.arm64: xcrun --sdk iphonesimulator clang -target arm64-apple-ios-simulator-simulator
-CPP-iphonesimulator.arm64: xcrun --sdk iphonesimulator clang -target arm64-apple-ios-simulator-simulator -E
+CC-iphonesimulator.arm64: xcrun --sdk iphonesimulator clang -target arm64-apple-ios-simulator
+CPP-iphonesimulator.arm64: xcrun --sdk iphonesimulator clang -target arm64-apple-ios-simulator -E
CFLAGS-iphonesimulator.arm64: -mios-simulator-version-min=12.0
LDFLAGS-iphonesimulator.arm64: -mios-simulator-version-min=12.0
BZIP2_SRCDIR-iphonesimulator.arm64: build/iOS-simulator/iphonesimulator.arm64/bzip2-1.0.8 |
Kylmakalle
suggested changes
Aug 27, 2025
Kylmakalle
suggested changes
Aug 30, 2025
There was a problem hiding this comment.
@skribka04 I'm not sure why you've dismissed my review. Do you plan to push the changes or should I reopen my own PR #3427?
|
Re-opened my PR #3427 that solves visionOS build issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Makefile, all targets (including simulators) are predefined, and the existing ifeq construct was appending an extra "-simulator" suffix to already simulator targets. As a result, identifiers like "iphoneos-simulator-simulator" were generated and the build failed.