fix(deep-link): handler not set as default on linux #2844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`xdg-mime default` needs to be given the full mimetype, not just the protocol on its own
Package Changes Through 06e26a5There are 6 changes which include barcode-scanner with minor, barcode-scanner-js with minor, deep-link with patch, deep-link-js with patch, window-state with minor, window-state-js with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
just check that it isn't already in there before appending it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the usage of xdg-mime was incorrect, we have to pass the full mime type including the
x-scheme-handler/part to properly set the generated .desktop as the default handler for the protocol. this PR simply addresses that.i have tested this by checking with Kesomannen/gale using
xdg-mime query defaultto check that it previously did not set the default correctly and that with this change it does.also fixes an issue that can occur if a tauri app using the plugin were to call the deep link register function more than once: it would continue to append to the existing .desktop file with the MimeType even if it was already in the existing .desktop file meaning you would end up with a huge MimeType section with as many duplicate entries as times the function has ever been called.