-
Notifications
You must be signed in to change notification settings - Fork 404
fix(upload): fix download() locks main thread on Android #2838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(upload): fix download() locks main thread on Android #2838
Conversation
Package Changes Through 9549d50There are 8 changes which include barcode-scanner with minor, barcode-scanner-js with minor, upload with patch, upload-js with patch, window-state with minor, window-state-js with minor, fs with patch, fs-js with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
3d030df
to
578625a
Compare
Tested upload demo on the following platforms:
Verified no locking of the main (UI) thread occurs when downloading or uploading. ^ When testing on Windows, I ran into the issues described in #2852. Switching to the Brownfield pattern in a local branch allowed me to test and validate the behavior was correct. |
@lucasfernog Fixed this issue. FYI - I noticed mobile support isn't added in the example project; I had to manually run |
Added tests for |
e011f5f
to
87c344a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the pr just a nitpick annotated and we'll also need a changefile :) (check .changes dir for examples)
8fb9ad0
to
667a0d2
Compare
Thanks for the review @FabianLars! Just pushed a commit to resolve your comments. |
f93d2d5
to
2cd12e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks :)
amazing PR! |
Fixed:
#2593
Key Changes
upload
methoddownload
orupload
commandfile_to_body
functionScreenshots
