(store): Improved type-safety of JavaScript functions #2791
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposition to overhaul the typescript definitions of
store
plugin.Why?
Current approach is error prone and cumbersome to work with. Setters are basically untyped and getters require manual type provisioning for each call.
Note
As far as TypeScript types go, this is a breaking change.
Disclaimer
Everything written by hand. No form of "AI" was involved. Feel free to ask questions about the code.
Example
Example below is outlining the workflow and areas of improvement.