feat(stronghold): support secp256k1 curve #2724
Conversation
Package Changes Through 4303383There are 2 changes which include autostart with minor, autostart-js with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
There was a problem hiding this comment.
Thanks for the PR! I don't think there's anyone from those who worked on the stronghold plugin available at the moment but i'll try my best 😅
For now just a small question (see comment below).
To merge the PR we'll also need a changefile in .changes similar to https://raw.githubusercontent.com/Legend-Master/plugins-workspace/refs/heads/window-state-optional-flags/.changes/window-state-optional-flags.md for example
| GetEvmAddress { | ||
| #[serde(rename = "privateKey")] | ||
| private_key: LocationDto, | ||
| }, | ||
| Secp256k1EcdsaSign { | ||
| flavor: Secp256k1EcdsaFlavor, | ||
| #[serde(rename = "privateKey")] | ||
| private_key: LocationDto, | ||
| msg: String, | ||
| }, |
There was a problem hiding this comment.
i couldn't try the changes yet but is this enum not missing a Secp256k1Ecdsa variant?
| * @param privateKeyLocation The location of the private key. Must be the `outputLocation` of a previous call to `deriveSLIP10`. | ||
| * @returns A promise resolving to the public key hex string. | ||
| * | ||
| * @since 2.1.0 |
There was a problem hiding this comment.
| * @since 2.1.0 | |
| * @since 2.4.0 |
| * @param privateKeyLocation The location of the private key. Must be the `outputLocation` of a previous call to `deriveSLIP10`. | ||
| * @returns A promise resolving to the EVM address | ||
| * | ||
| * @since 2.1.0 |
There was a problem hiding this comment.
| * @since 2.1.0 | |
| * @since 2.4.0 |
| * @param msg The message to sign. | ||
| * @returns A promise resolving to the signature hex string. | ||
| * | ||
| * @since 2.1.0 |
There was a problem hiding this comment.
| * @since 2.1.0 | |
| * @since 2.4.0 |
No description provided.