feat(ws): support blob type #338
Open
+186
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #338 +/- ##
=======================================
Coverage 81.56% 81.56%
=======================================
Files 24 24
Lines 3537 3537
=======================================
Hits 2885 2885
Misses 652 652 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the blob data type in the taos-ws-py Python binding for TDengine. The implementation enables handling blob values across SQL queries, prepared statements, and message queue operations.
- Adds blob data type support to value handling and prepared statement binding
- Includes comprehensive test coverage for blob operations via SQL, prepared statements, and TMQ
- Updates dependency to use a feature branch that includes blob support
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 18 comments.
Show a summary per file
| File | Description |
|---|---|
| taos-ws-py/src/lib.rs | Adds blob value handling and blob_to_column function for prepared statements |
| taos-ws-py/src/common.rs | Implements blob value conversion to Python objects |
| taos-ws-py/tests/test_blob.py | Comprehensive test suite covering blob operations in SQL, prepared statements, and TMQ |
| taos-ws-py/src/consumer.rs | Adds documentation comment for poll method |
| taos-ws-py/Cargo.toml | Updates dependency branch to feat/TD-35106 for blob support |
| .github/workflows/taos-ws-py-compatibility.yml | Adds TEST_TD_3360 environment variable to skip blob tests |
| Multiple test files | Removes commented-out code for cleanup |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support blob type
Jira: https://jira.taosdata.com:18080/browse/TD-35104
Checklist
Please check the items in the checklist if applicable.