feat+docs(playbooks) Ensure sentinel role is created, update all readmes + docs(workbooks) #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated files # Conflicts: # Solutions/SlackAudit/Package/mainTemplate.json
…ed images & readme
…ted images & readme
…ted images & readme
…ed images & readme
Tanium-Nicole
force-pushed
the
feature/tanium/update-playbook-readmes
branch
from
c3ca59b to
5ad55dd
Compare
|
This resolves SENTINEL-170 & SENTINEL-26 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Managed Identity
The previous PRs updated our playbooks to use managed identity, however the user would still have to grant the
Microsoft Sentinel Contributorrole to each playbook after creation. While managed identity is better from best practices, that still left an extra action for our users to take.This PR updates each of the playbooks to also add that needed role to the playbook, so that there are not post-deployment actions required by our users.
Additionally, this meant that both the readme and arm json was updated to remove the post-deployment action notes.
Updated playbook readmes & images
Each of the readmes was updated for spelling errors, a general refresh and to make sure the prerequisites were correct. Additionally, due to the reorganization of the playbooks new screenshots were added.
Updated workbook images
In our last release 3.0.0 we forgot to include updated workbook screenshots, since currently there is a bug in Azure where those preview images are not displaying. Now they are updated, for whenever Azure resolves their bug.