fix: remove all the array index keys when there is more than one #789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Query::position_info_at()` function can return one index when the value is a non-empty array. In this case, the `Query::lookup_keys()` function will add another one, resulting in two index keys. But the code was only removing one, causing hover to break for keys with a non-empty array value. This change avoids the issue by removing index keys in a while loop. Closes tamasfe#788
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Query::position_info_at()function can return one index when the value is a non-empty array. In this case, theQuery::lookup_keys()function will add another one, resulting in two index keys. But the code was only removing one, causing hover to break for keys with a non-empty array value.This change avoids the issue by removing index keys in a while loop.
Closes #788