Allow dates in identifiers #749
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the toml standard, bare keys may only contain the characters A-Za-z0-9_- and they must contain at least one character. This allows identifiers to look like dates, e.g. 2024-01-01. Due to a bug in the lexing library logos, some-like identifiers are incorrectly being parsed as INTEGER tokens, while date-like identifiers in table names are being parsed as DATE tokens as they should be. Due to this bug, date-like identifiers were being accepted in some situations by taplo while they were rejected in other situations. This commit only allows DATE tokens in identifiers (as they should be, according to the standard). It does not fix the underlying bug that sometimes produces incorrect INTEGER tokens instead of DATE tokens.
arp242
added a commit
to toml-lang/toml-test
that referenced
this pull request
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the toml standard, bare keys may only contain the characters A-Za-z0-9_- and they must contain at least one character. This allows identifiers to look like dates, e.g. 2024-01-01.
Due to a bug in the lexing library logos, date-like identifiers in assignments are incorrectly being parsed as INTEGER tokens, while date-like identifiers in table names are being parsed as DATE tokens (as they should be). Due to this bug, date-like identifiers were being accepted in some situations by taplo while they were rejected in other situations.
This commit only allows DATE tokens in identifiers (as they should be, according to the standard). It does not fix the underlying bug that sometimes produces incorrect INTEGER tokens instead of DATE tokens.
Fixes #571