allow passing context to GetCertificate #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 17, 2024
mholt
approved these changes
May 17, 2024
bradfitz
reviewed
May 17, 2024
tscert.go
Outdated
| ) | ||
|
|
||
| func defaultDialer(ctx context.Context, network, addr string) (net.Conn, error) { | ||
| func DefaultDialer(ctx context.Context, network, addr string) (net.Conn, error) { |
There was a problem hiding this comment.
this isn't the best name imo. And would need docs.
There was a problem hiding this comment.
It sounds like a type or var. A func would sound like a verb.
There was a problem hiding this comment.
just Dial? DialLocalAPI?
There was a problem hiding this comment.
went with DialLocalAPI.
Add a new GetCertificateWithContext to allow passing an existing context. Also export the default dialer method, so that callers that override TailscaledDialer can fall back to this if other methods fail. Signed-off-by: Will Norris <will@tailscale.com>
bradfitz
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new GetCertificateWithContext to allow passing an existing context. Also export the default dialer method, so that callers that override TailscaledDialer can fall back to this if other methods fail.
This is being added to support the caddy-tailscale plugin to work with caddy's auto_https functionality. See tailscale/caddy-tailscale#53
/cc @mholt