Skip to content

keys: added expirySeconds, scopes & tags to the key response #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025

Conversation

mcoulombe
Copy link
Contributor

Copy link

review-ai-agent bot commented Jun 13, 2025

Pull Request Revisions

RevisionDescription
r1
Key struct enhanced with new fieldsAdded ExpirySeconds, Scopes, and Tags fields to Key struct, updated test cases accordingly

☑️ AI review skipped for r1
Help React with emojis to give feedback on AI-generated reviews:
  • 👍 means the feedback was helpful and actionable
  • 👎 means the feedback was incorrect or unhelpful
💬 Replying to feedback with a comment helps us improve the system. Your input also contributes to shaping future interactions with the AI reviewer.

We'd love to hear from you—reach out anytime at team@review.ai.

@mcoulombe mcoulombe merged commit 8dcb33e into main Jun 16, 2025
2 checks passed
@mcoulombe mcoulombe deleted the max/expiryseconds-scopes-tags-on-key-response branch June 16, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants