logging: support UploadPeriodMinutes and CompressionFormat parameters #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxtoacart
force-pushed
the
percy/corp26860
branch
from
2b39864 to
4e08dc3
Compare
oxtoacart
commented
Mar 4, 2025
| @@ -20,7 +20,7 @@ jobs: | |||
| echo "module=$(go env GOMODCACHE)" | tee -a $GITHUB_OUTPUT | |||
|
|
|||
| - name: Set up cache | |||
| uses: actions/cache@v2 | |||
| uses: actions/cache@v4 | |||
There was a problem hiding this comment.
Drive-by to make GitHub happy.
mpminardi
reviewed
Mar 4, 2025
logging_test.go
Outdated
| S3AccessKeyID: "my-access-key-id", | ||
| S3RoleARN: "my-role-arn", | ||
| S3ExternalID: "my-external-id", | ||
| } | ||
| server.ResponseBody = expectedLogstream | ||
|
|
||
| actualWebhook, err := client.Logging().LogstreamConfiguration(context.Background(), LogTypeConfig) |
There was a problem hiding this comment.
Whoops this was me a while back with bad copy / paste 🤦
Suggested change
| actualWebhook, err := client.Logging().LogstreamConfiguration(context.Background(), LogTypeConfig) | |
| actualLogstream, err := client.Logging().LogstreamConfiguration(context.Background(), LogTypeConfig) |
mpminardi
approved these changes
Mar 4, 2025
Updates tailscale/corp#26860 Signed-off-by: Percy Wegmann <percy@tailscale.com>
oxtoacart
force-pushed
the
percy/corp26860
branch
from
4e08dc3 to
cbd4efb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates tailscale/corp#26860