Skip to content

policyfile: add SetAndGet method #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2025
Merged

Conversation

oxtoacart
Copy link
Collaborator

This variant of Set returns the resulting ACL with its updated ETag.

Updates tailscale/corp#22748

@oxtoacart oxtoacart closed this Feb 21, 2025
@oxtoacart oxtoacart reopened this Feb 21, 2025
@oxtoacart oxtoacart force-pushed the percy/corp22748-policyfile2 branch from a5f1790 to f5a6de8 Compare February 21, 2025 21:35
@oxtoacart oxtoacart requested a review from mpminardi February 21, 2025 21:37
policyfile.go Outdated
@@ -221,6 +221,32 @@ func (pr *PolicyFileResource) Set(ctx context.Context, acl any, etag string) err
return pr.do(req, nil)
}

// Set sets the [ACL] for the tailnet and returns the resulting [ACL].
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Set sets the [ACL] for the tailnet and returns the resulting [ACL].
// SetAndGet sets the [ACL] for the tailnet and returns the resulting [ACL].

This variant of Set returns the resulting ACL with its updated ETag.

Updates tailscale/corp#22748

Signed-off-by: Percy Wegmann <percy@tailscale.com>
@oxtoacart oxtoacart force-pushed the percy/corp22748-policyfile2 branch from f5a6de8 to 4ad11a0 Compare February 22, 2025 01:20
@oxtoacart oxtoacart merged commit b9e1df8 into main Feb 22, 2025
2 checks passed
@oxtoacart oxtoacart deleted the percy/corp22748-policyfile2 branch February 22, 2025 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants