Skip to content

android: touchless auth key login #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025
Merged

Conversation

barnstar
Copy link
Member

@barnstar barnstar commented Jun 9, 2025

updates tailscale/corp#29482

If an authKey is detected in the mdm payload, we will now skip the onboarding flows and several of the other non-mandatory permission prompts.

@barnstar barnstar requested review from nickkhyl and kari-ts June 9, 2025 18:58
Copy link

review-ai-agent bot commented Jun 9, 2025

Pull Request Revisions

RevisionDescription
r7
Inverted permission prompt logic conditionModified PromptForMissingPermissions function to change condition from !viewModel.skipPromptsForAuthKeyLogin() to viewModel.skipPromptsForAuthKeyLogin()
r6
Enhanced auth key login prompt checkModified skipPromptsForAuthKeyLogin() to check for non-empty auth key value, improving validation logic
r5
Added MDM settings update logicIntegrated RestrictionsManager to update MDM settings within the application launch scope
r4
Renamed methods for clarityRenamed several methods to improve semantic clarity, including permission and onboarding-related function names
r3
Modified onboarding and permissions flowUpdated MainActivity and MainViewModel to conditionally skip user permissions and onboarding based on MDM settings and auth key presence
r2
Added MDM settings update logicRetrieves RestrictionsManager and updates MDM settings before checking for MDM authentication key
r1
MDM login skips onboarding and permissionsAdded logic to skip onboarding and user-interactive permission prompts when MDM authentication key is present

☑️ AI review skipped after 5 revisions, comment with `/review` to review again
Help React with emojis to give feedback on AI-generated reviews:
  • 👍 means the feedback was helpful and actionable
  • 👎 means the feedback was incorrect or unhelpful
💬 Replying to feedback with a comment helps us improve the system. Your input also contributes to shaping future interactions with the AI reviewer.

We'd love to hear from you—reach out anytime at team@review.ai.

@barnstar barnstar force-pushed the jonathan/authkey-auto-login branch from c5a36c2 to 3c1dde1 Compare June 9, 2025 19:14
@barnstar barnstar force-pushed the jonathan/authkey-auto-login branch from 3c1dde1 to 2be3b0f Compare June 9, 2025 19:29
@@ -219,6 +225,10 @@ class MainViewModel(private val vpnViewModel: VpnViewModel) : IpnViewModel() {
}

fun checkIfTaildropDirectorySelected() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the right taildrop behavior in the touchless case? select no directory because they will never use taildrop, or select one for them?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we just leave it for now and the user can select a directory. This primarily intended for POS terminals where taildrop (and the UI really) isn't intended to get used.

@barnstar barnstar force-pushed the jonathan/authkey-auto-login branch from 2be3b0f to c8b4080 Compare June 11, 2025 13:51
@barnstar barnstar force-pushed the jonathan/authkey-auto-login branch from c8b4080 to 63a725b Compare June 11, 2025 14:35
@barnstar barnstar requested a review from kari-ts June 11, 2025 14:36
@barnstar barnstar force-pushed the jonathan/authkey-auto-login branch from 63a725b to 25327b7 Compare June 11, 2025 14:42
updates tailscale/corp#29482

If an authKey is detected in the mdm payload, we will now skip the
onboarding flows and several of the other non-mandatory permission
prompts.

Signed-off-by: Jonathan Nobels <jonathan@tailscale.com>
@barnstar barnstar force-pushed the jonathan/authkey-auto-login branch from 25327b7 to 0abfa21 Compare June 11, 2025 14:44
@barnstar barnstar merged commit 28f1931 into main Jun 11, 2025
4 checks passed
@barnstar barnstar deleted the jonathan/authkey-auto-login branch June 11, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants