log: terminate OSC escape sequences with ST code #3974
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit f26cb34 introduced some OSC escape sequences that resulted in all mkosi output being hidden when using the Kitty terminal: kovidgoyal/kitty#9139 This commit rectifies the situation by correctly sending the <ST> code after <OSC> has been sent, thereby ending the OSC sequence. Ref: - https://en.wikipedia.org/wiki/ANSI_escape_code#Operating_System_Command_sequences - https://sw.kovidgoyal.net/kitty/shell-integration/#notes-for-shell-developers - https://ghostty.org/docs/vt/concepts/sequences#osc-sequences
|
Thanks for the contribution. @DaanDeMeyer already saw your issue against kitty and I put up #3973 earlier to fix this. It also fixes a bit more, since during testing I noticed that konsole behaves a bit weirdly there. Could you see whether #3973 fixes this for you? |
|
I totally missed your fix! Looks like I should've checked before opening this PR. Yeah, your #3973 fixes the problem for me too. Thanks much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit f26cb34 introduced some OSC escape sequences that resulted in all mkosi output being hidden when using the Kitty terminal: kovidgoyal/kitty#9139
This commit rectifies the situation by correctly sending the
STcode afterOSChas been sent, thereby ending the OSC sequence.Ref: