Skip to content

Add missing bar to separate filename #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 28, 2024
Merged

Conversation

howjmay
Copy link
Collaborator

@howjmay howjmay commented Sep 27, 2024

No description provided.

CONTRIBUTING.md Outdated
@@ -47,7 +47,7 @@ However, participation requires adherence to fundamental ground rules:
Software requirement: [clang-format](https://clang.llvm.org/docs/ClangFormat.html) version 12 or later.

This repository consistently contains an up-to-date `.clang-format` file with rules that match the explained ones.
For maintaining a uniform coding style, execute the command `clang-format -i *.[ch]`.
For maintaining a uniform coding style, execute the command `clang-format -i *.[c|h]`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are running bash, the changed command does not work.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should i change it to clang-format -i *.{c,h} or keep in the original way? For me clang-format -i *.{c,h} is more clear. Not sure how other people think about it

@jserv jserv merged commit 38e0907 into sysprog21:master Sep 28, 2024
8 checks passed
@jserv
Copy link
Contributor

jserv commented Sep 28, 2024

Thank @howjmay for contributing!

@howjmay
Copy link
Collaborator Author

howjmay commented Sep 29, 2024

Thanks!

@howjmay howjmay deleted the typo branch September 29, 2024 14:02
vestata pushed a commit to vestata/rv32emu that referenced this pull request Jan 24, 2025
Add missing bar to separate filename
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants