-
Notifications
You must be signed in to change notification settings - Fork 113
Avoid re-fetching binaries when they exist #492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improve git commit messages.
If you tend to trigger tests, specify "WIP:" in the subject.
Rather than checking for the existence of prebuilt executable filenames, I prefer calculating and comparing their hash values with pre-calculated ones. For verifying the hash of a file or directory, see the Line 47 in abb1135
|
fac8976
to
a4dbcd9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enhance the git commit message by providing more details, specifically explaining how the SHA1 value is handled.
|
a4dbcd9
to
e3fe2cb
Compare
I’m still confused about file suffixes related to CSV. Could you please provide more details? |
The contents of |
We fetch the SHA1 first and verify the binaries. If any verification fails, the returned value of the "verify" macro becomes non-zero. Only if the verification fails, the download begins. Close sysprog21#491
e3fe2cb
to
4218524
Compare
So, are the |
I think both of them are the same with Or, do you care about the |
I was wondering, since we have the space-separated |
No, but any file in Or, we can simply clear the repository, but not in this pull request. |
Agree. From my perspective, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now, LGTM.
Avoid re-fetching binaries when they exist
Now, we fetch the SHA1 first and verify the binaries. Only if the check fails, the download begins.