Align version check #301
Merged
Align version check #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliechiou
changed the title
You should revise all C source files to make the above statement practically fit. |
The condition ">=" is used to align all version checks, improving code consistency and readability.
|
Thank @charliechiou for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The condition ">=" is used to align all version checks, improving code consistency and readability.
Summary by Bito
This pull request enhances code consistency and readability by aligning the version check for the class_create function in static_key.c with chardev.c and standardizing version checks across multiple files. The condition was modified from '<' to '>=', improving overall code quality, logical consistency, and maintainability across related files.Unit tests added: False
Estimated effort to review (1-5, lower is better): 2