-
Notifications
You must be signed in to change notification settings - Fork 53
feat(secure-policies): support new and fix existing fields in malware policy #657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @ombellare , is this ready for review? Can you add a small description of the purpose of the PR? Thanks! |
* Add support for additional secure drift policy fields * Address review comments * Fixed spacing issue --------- Co-authored-by: Fede Barcelona <fede_rico_94@hotmail.com>
e6bf418
to
5fc61e8
Compare
Hi @airadier , please hold off on reviewing this PR for now since there is a schema change that might need to be communicated to customers before proceeding to merge the fix. |
Renamed resource from 'policy_1' to 'policy_3' and data source from 'policy_2' to 'policy_4' in malware policy test to improve clarity and avoid naming conflicts.
tembleking
approved these changes
Jul 22, 2025
jbainbridgesysdig
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(secure-policy): Add following fields to support malware runtime policy:
use_yara_rules
(bool)ignore_hashes
(list of string hashes)use_regex
(bool)ignore_paths
(list of string paths to ignore from hash calculation)Also fixed bug with current schema which does not support multiple hashes to be added to the
additional_hashes
andignore_hashes
field. Due to this schema change, customers will now need to change existing terraform definitions in their malware policies from:to
New hashes can now be added like: