Skip to content

Updating the filter expression description for the tools #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 4, 2025
Merged

Updating the filter expression description for the tools #5

merged 2 commits into from
Jul 4, 2025

Conversation

S3B4SZ17
Copy link
Collaborator

@S3B4SZ17 S3B4SZ17 commented Jul 3, 2025

Updating the filter expression description for the tools

Changes

  • Updating the filter expression description for the tools that need it. Each API endpoint will define the supported fields in the description and examples
  • The common query language expressions and operators are defined now in a separate resource
  • Adding a default non-root user to the container definition

@S3B4SZ17 S3B4SZ17 requested a review from a team as a code owner July 3, 2025 06:28
@S3B4SZ17 S3B4SZ17 force-pushed the fix/tool-filters branch 9 times, most recently from 3c70b96 to 220bec7 Compare July 3, 2025 07:27
alecron
alecron approved these changes Jul 3, 2025
View reviewed changes
Copy link
Collaborator

@alecron alecron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but we should update docs too

utils/mcp_server.py
@@ -233,3 +234,54 @@ def add_tools(mcp: FastMCP) -> None:
"""
),
)


def add_resources(mcp: FastMCP) -> None:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should add the resources to the README too.

alecron
alecron reviewed Jul 3, 2025
View reviewed changes
Copy link
Collaborator

@alecron alecron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check test_tag workflow too

@S3B4SZ17 S3B4SZ17 force-pushed the fix/tool-filters branch from 220bec7 to b875c0d Compare July 3, 2025 07:29
@S3B4SZ17
fix: Changing the description of some tools for the filter query lang…
ddd9a19 
…uage

Signed-off-by: S3B4SZ17 <sebastian.zumbado@sysdig.com>
@S3B4SZ17 S3B4SZ17 force-pushed the fix/tool-filters branch from b875c0d to ddd9a19 Compare July 3, 2025 07:36
@S3B4SZ17
Updating the init and conventions config of the mcp server
2923335 
Signed-off-by: S3B4SZ17 <sebastian.zumbado@sysdig.com>
@S3B4SZ17 S3B4SZ17 merged commit ca74936 into beta Jul 4, 2025
3 checks passed
@S3B4SZ17 S3B4SZ17 deleted the fix/tool-filters branch July 4, 2025 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecron alecron alecron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@S3B4SZ17 @alecron