Skip to content

feat(admission-controller): add PDB, enable HPA and deprecate scanning #2174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 26, 2025

Conversation

tembleking
Copy link
Member

What this PR does / why we need it:

  • Adds a Pod Disruption Budget
  • Enables the creation of the Horizontal Pod Autoscaler by default, to ensure the deployment scales up in high demanding environments.
  • Disables and deprecates the scanning deployment by default. This scanner is not present either in the SaaS product nor in on-prem installations anymore. It will be removed in a later version.

Checklist

  • Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
  • Chart Version bumped for the respective charts
  • Variables are documented in the README.md (or README.tpl in some charts)
  • Check GithubAction checks (like lint) to avoid merge-check stoppers
  • All test files are added in the tests folder of their respective chart and have a "_test" suffix

@tembleking tembleking self-assigned this Mar 11, 2025
@tembleking tembleking requested a review from a team as a code owner March 11, 2025 14:10
@tembleking tembleking enabled auto-merge (squash) March 12, 2025 15:24
@tembleking tembleking disabled auto-merge March 26, 2025 08:33
@tembleking tembleking merged commit 121520c into main Mar 26, 2025
4 checks passed
@tembleking tembleking deleted the feat-add-pdb-to-admission-controller branch March 26, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants