Ensure jsonconvertors use invariant culture

Author: synercoder

src/Synercoding.Primitives/JsonConverters/PointJsonConverter.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Globalization;
 using System.Text.Json;
 using System.Text.Json.Serialization;
 
@@ -72,6 +73,6 @@ public override Point Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSe
     /// <param name="options">An object that specifies serialization options to use.</param>
     public override void Write(Utf8JsonWriter writer, Point value, JsonSerializerOptions options)
     {
-        writer.WriteStringValue(value.ToString());
+        writer.WriteStringValue(value.ToString(CultureInfo.InvariantCulture));
     }
 }

src/Synercoding.Primitives/JsonConverters/RectangleJsonConverter.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Globalization;
 using System.Text.Json;
 using System.Text.Json.Serialization;
 
@@ -80,6 +81,6 @@ public override Rectangle Read(ref Utf8JsonReader reader, Type typeToConvert, Js
     /// <param name="options">An object that specifies serialization options to use.</param>
     public override void Write(Utf8JsonWriter writer, Rectangle value, JsonSerializerOptions options)
     {
-        writer.WriteStringValue(value.ToString());
+        writer.WriteStringValue(value.ToString(CultureInfo.InvariantCulture));
     }
 }

src/Synercoding.Primitives/JsonConverters/SizeJsonConverter.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Globalization;
 using System.Text.Json;
 using System.Text.Json.Serialization;
 
@@ -72,6 +73,6 @@ public override Size Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSer
     /// <param name="options">An object that specifies serialization options to use.</param>
     public override void Write(Utf8JsonWriter writer, Size value, JsonSerializerOptions options)
     {
-        writer.WriteStringValue(value.ToString());
+        writer.WriteStringValue(value.ToString(CultureInfo.InvariantCulture));
     }
 }

src/Synercoding.Primitives/JsonConverters/SpacingJsonConverter.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Globalization;
 using System.Text.Json;
 using System.Text.Json.Serialization;
 
@@ -80,6 +81,6 @@ public override Spacing Read(ref Utf8JsonReader reader, Type typeToConvert, Json
     /// <param name="options">An object that specifies serialization options to use.</param>
     public override void Write(Utf8JsonWriter writer, Spacing value, JsonSerializerOptions options)
     {
-        writer.WriteStringValue(value.ToString());
+        writer.WriteStringValue(value.ToString(CultureInfo.InvariantCulture));
     }
 }

src/Synercoding.Primitives/JsonConverters/UnitJsonConverter.cs

@@ -44,7 +44,7 @@ public override Unit Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSer
     /// <param name="options">An object that specifies serialization options to use.</param>
     public override void Write(Utf8JsonWriter writer, Unit value, JsonSerializerOptions options)
     {
-        writer.WriteStringValue(value.ToString());
+        writer.WriteStringValue(value.ToString(CultureInfo.InvariantCulture));
     }
 }
 

src/Synercoding.Primitives/JsonConverters/ValueJsonConverter.cs

@@ -73,6 +73,6 @@ public override Value Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSe
     /// <param name="options">An object that specifies serialization options to use.</param>
     public override void Write(Utf8JsonWriter writer, Value value, JsonSerializerOptions options)
     {
-        writer.WriteStringValue(value.ToString());
+        writer.WriteStringValue(value.ToString(CultureInfo.InvariantCulture));
     }
 }

src/Synercoding.Primitives/PackageDetails.props

@@ -10,7 +10,7 @@
     <Product>Synercoding.Primitives</Product>
     <Title>Synercoding.Primitives</Title>
     <Description>Primitives with units attached (think mm, cm, in, px) that can be used for 2D graphics.</Description>
-    <PackageReleaseNotes>Limit to latest .NET version (8) and add System.Json serialization support.</PackageReleaseNotes>
+    <PackageReleaseNotes>Added IParsable support and added overload for ToString to be culture aware.</PackageReleaseNotes>
   </PropertyGroup>
 
 </Project>

src/Synercoding.Primitives/Unit.cs

@@ -44,9 +44,17 @@ public bool Equals(Unit other)
 
     /// <inheritdoc/>
     public override string ToString()
+        => ToString(null);
+
+    /// <summary>
+    /// Returns a string representation of the unit using the specified format provider.
+    /// </summary>
+    /// <param name="formatProvider">The format provider to use for formatting numeric values in pixel units (DPI). Ignored for other unit types.</param>
+    /// <returns>A string representation of the unit. For pixel units, returns "dpi(value)" format. For other units, returns their short form (e.g., "mm", "cm", "in", "pts").</returns>
+    public string ToString(IFormatProvider? formatProvider)
         => Designation switch
         {
-            UnitDesignation.Pixels => $"dpi({PerInch})",
+            UnitDesignation.Pixels => $"dpi({PerInch.ToString(formatProvider)})",
             var x => x.Shortform()
         };