Made primitives implement IParsable<Unit>, dpi/pixel units can now be made with doubles instead of ints, and becaus of the IParsable, IFormatProvider is supported during parsing.

Author: synercoder

src/Synercoding.Primitives/JsonConverters/PointJsonConverter.cs

@@ -4,10 +4,24 @@
 
 namespace Synercoding.Primitives.JsonConverters;
 
+/// <summary>
+/// Converts a <see cref="Point"/> object to or from JSON.
+/// </summary>
 public class PointJsonConverter : JsonConverter<Point>
 {
+    /// <summary>
+    /// Thread-safe instance of <see cref="PointJsonConverter"/> to be reused.
+    /// </summary>
     public static PointJsonConverter Instance { get; } = new();
 
+    /// <summary>
+    /// Read a <see cref="Point"/> object from the <paramref name="reader"/>.
+    /// </summary>
+    /// <param name="reader">The reader that should contain a <see cref="Point"/>.</param>
+    /// <param name="typeToConvert">The expected type to convert.</param>
+    /// <param name="options">An object that specifies serialization options to use.</param>
+    /// <returns>The <see cref="Point"/> that was read from the <paramref name="reader"/>.</returns>
+    /// <exception cref="JsonException">Throws when the <paramref name="reader"/> does not contain <see cref="Point"/>.</exception>
     public override Point Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
     {
         if (reader.TokenType == JsonTokenType.String)
@@ -50,6 +64,12 @@ public override Point Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSe
         throw new JsonException();
     }
 
+    /// <summary>
+    /// Write a <see cref="Point"/> to the <paramref name="writer"/>.
+    /// </summary>
+    /// <param name="writer">Writer to write the <see cref="Point"/> to.</param>
+    /// <param name="value">The <see cref="Point"/> to write.</param>
+    /// <param name="options">An object that specifies serialization options to use.</param>
     public override void Write(Utf8JsonWriter writer, Point value, JsonSerializerOptions options)
     {
         writer.WriteStringValue(value.ToString());

src/Synercoding.Primitives/JsonConverters/RectangleJsonConverter.cs

@@ -4,10 +4,24 @@
 
 namespace Synercoding.Primitives.JsonConverters;
 
+/// <summary>
+/// Converts a <see cref="Rectangle"/> object to or from JSON.
+/// </summary>
 public class RectangleJsonConverter : JsonConverter<Rectangle>
 {
+    /// <summary>
+    /// Thread-safe instance of <see cref="RectangleJsonConverter"/> to be reused.
+    /// </summary>
     public static RectangleJsonConverter Instance { get; } = new();
 
+    /// <summary>
+    /// Read a <see cref="Rectangle"/> object from the <paramref name="reader"/>.
+    /// </summary>
+    /// <param name="reader">The reader that should contain a <see cref="Rectangle"/>.</param>
+    /// <param name="typeToConvert">The expected type to convert.</param>
+    /// <param name="options">An object that specifies serialization options to use.</param>
+    /// <returns>The <see cref="Rectangle"/> that was read from the <paramref name="reader"/>.</returns>
+    /// <exception cref="JsonException">Throws when the <paramref name="reader"/> does not contain <see cref="Rectangle"/>.</exception>
     public override Rectangle Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
     {
         if (reader.TokenType == JsonTokenType.String)
@@ -58,6 +72,12 @@ public override Rectangle Read(ref Utf8JsonReader reader, Type typeToConvert, Js
         throw new JsonException();
     }
 
+    /// <summary>
+    /// Write a <see cref="Rectangle"/> to the <paramref name="writer"/>.
+    /// </summary>
+    /// <param name="writer">Writer to write the <see cref="Rectangle"/> to.</param>
+    /// <param name="value">The <see cref="Rectangle"/> to write.</param>
+    /// <param name="options">An object that specifies serialization options to use.</param>
     public override void Write(Utf8JsonWriter writer, Rectangle value, JsonSerializerOptions options)
     {
         writer.WriteStringValue(value.ToString());

src/Synercoding.Primitives/JsonConverters/SizeJsonConverter.cs

@@ -4,10 +4,24 @@
 
 namespace Synercoding.Primitives.JsonConverters;
 
+/// <summary>
+/// Converts a <see cref="Size"/> object to or from JSON.
+/// </summary>
 public class SizeJsonConverter : JsonConverter<Size>
 {
+    /// <summary>
+    /// Thread-safe instance of <see cref="SizeJsonConverter"/> to be reused.
+    /// </summary>
     public static SizeJsonConverter Instance { get; } = new();
 
+    /// <summary>
+    /// Read a <see cref="Size"/> object from the <paramref name="reader"/>.
+    /// </summary>
+    /// <param name="reader">The reader that should contain a <see cref="Value"/>.</param>
+    /// <param name="typeToConvert">The expected type to convert.</param>
+    /// <param name="options">An object that specifies serialization options to use.</param>
+    /// <returns>The <see cref="Size"/> that was read from the <paramref name="reader"/>.</returns>
+    /// <exception cref="JsonException">Throws when the <paramref name="reader"/> does not contain <see cref="Size"/>.</exception>
     public override Size Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
     {
         if (reader.TokenType == JsonTokenType.String)
@@ -50,6 +64,12 @@ public override Size Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSer
         throw new JsonException();
     }
 
+    /// <summary>
+    /// Write a <see cref="Size"/> to the <paramref name="writer"/>.
+    /// </summary>
+    /// <param name="writer">Writer to write the <see cref="Size"/> to.</param>
+    /// <param name="value">The <see cref="Size"/> to write.</param>
+    /// <param name="options">An object that specifies serialization options to use.</param>
     public override void Write(Utf8JsonWriter writer, Size value, JsonSerializerOptions options)
     {
         writer.WriteStringValue(value.ToString());

src/Synercoding.Primitives/JsonConverters/SpacingJsonConverter.cs

@@ -4,10 +4,24 @@
 
 namespace Synercoding.Primitives.JsonConverters;
 
+/// <summary>
+/// Converts a <see cref="Spacing"/> object to or from JSON.
+/// </summary>
 public class SpacingJsonConverter : JsonConverter<Spacing>
 {
+    /// <summary>
+    /// Thread-safe instance of <see cref="SpacingJsonConverter"/> to be reused.
+    /// </summary>
     public static SpacingJsonConverter Instance { get; } = new();
 
+    /// <summary>
+    /// Read a <see cref="Spacing"/> object from the <paramref name="reader"/>.
+    /// </summary>
+    /// <param name="reader">The reader that should contain a <see cref="Spacing"/>.</param>
+    /// <param name="typeToConvert">The expected type to convert.</param>
+    /// <param name="options">An object that specifies serialization options to use.</param>
+    /// <returns>The <see cref="Spacing"/> that was read from the <paramref name="reader"/>.</returns>
+    /// <exception cref="JsonException">Throws when the <paramref name="reader"/> does not contain <see cref="Spacing"/>.</exception>
     public override Spacing Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
     {
         if (reader.TokenType == JsonTokenType.String)
@@ -58,6 +72,12 @@ public override Spacing Read(ref Utf8JsonReader reader, Type typeToConvert, Json
         throw new JsonException();
     }
 
+    /// <summary>
+    /// Write a <see cref="Spacing"/> to the <paramref name="writer"/>.
+    /// </summary>
+    /// <param name="writer">Writer to write the <see cref="Spacing"/> to.</param>
+    /// <param name="value">The <see cref="Spacing"/> to write.</param>
+    /// <param name="options">An object that specifies serialization options to use.</param>
     public override void Write(Utf8JsonWriter writer, Spacing value, JsonSerializerOptions options)
     {
         writer.WriteStringValue(value.ToString());

src/Synercoding.Primitives/JsonConverters/UnitJsonConverter.cs

@@ -1,26 +1,47 @@
 using System;
+using System.Globalization;
 using System.Text.Json;
 using System.Text.Json.Serialization;
 
 namespace Synercoding.Primitives.JsonConverters;
 
+/// <summary>
+/// Converts a <see cref="Unit"/> object to or from JSON.
+/// </summary>
 public class UnitJsonConverter : JsonConverter<Unit>
 {
+    /// <summary>
+    /// Thread-safe instance of <see cref="UnitJsonConverter"/> to be reused.
+    /// </summary>
     public static UnitJsonConverter Instance { get; } = new();
 
+    /// <summary>
+    /// Read a <see cref="Unit"/> object from the <paramref name="reader"/>.
+    /// </summary>
+    /// <param name="reader">The reader that should contain a <see cref="Unit"/>.</param>
+    /// <param name="typeToConvert">The expected type to convert.</param>
+    /// <param name="options">An object that specifies serialization options to use.</param>
+    /// <returns>The <see cref="Unit"/> that was read from the <paramref name="reader"/>.</returns>
+    /// <exception cref="JsonException">Throws when the <paramref name="reader"/> does not contain <see cref="Unit"/>.</exception>
     public override Unit Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
     {
         if (reader.TokenType != JsonTokenType.String)
             throw new JsonException();
 
         var textValue = reader.GetString() ?? throw new JsonException();
 
-        if (Unit.TryParse(textValue, out var unit))
+        if (Unit.TryParse(textValue, CultureInfo.InvariantCulture, out var unit))
             return unit;
 
         throw new JsonException();
     }
 
+    /// <summary>
+    /// Write a <see cref="Unit"/> to the <paramref name="writer"/>.
+    /// </summary>
+    /// <param name="writer">Writer to write the <see cref="Unit"/> to.</param>
+    /// <param name="value">The <see cref="Unit"/> to write.</param>
+    /// <param name="options">An object that specifies serialization options to use.</param>
     public override void Write(Utf8JsonWriter writer, Unit value, JsonSerializerOptions options)
     {
         writer.WriteStringValue(value.ToString());

src/Synercoding.Primitives/JsonConverters/ValueJsonConverter.cs

@@ -1,20 +1,35 @@
 using System;
+using System.Globalization;
 using System.Text.Json;
 using System.Text.Json.Serialization;
 
 namespace Synercoding.Primitives.JsonConverters;
 
+/// <summary>
+/// Converts a <see cref="Value"/> object to or from JSON.
+/// </summary>
 public class ValueJsonConverter : JsonConverter<Value>
 {
+    /// <summary>
+    /// Thread-safe instance of <see cref="ValueJsonConverter"/> to be reused.
+    /// </summary>
     public static ValueJsonConverter Instance { get; } = new();
 
+    /// <summary>
+    /// Read a <see cref="Value"/> object from the <paramref name="reader"/>.
+    /// </summary>
+    /// <param name="reader">The reader that should contain a <see cref="Value"/>.</param>
+    /// <param name="typeToConvert">The expected type to convert.</param>
+    /// <param name="options">An object that specifies serialization options to use.</param>
+    /// <returns>The <see cref="Value"/> that was read from the <paramref name="reader"/>.</returns>
+    /// <exception cref="JsonException">Throws when the <paramref name="reader"/> does not contain <see cref="Value"/>.</exception>
     public override Value Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
     {
         if (reader.TokenType == JsonTokenType.String)
         {
             var textValue = reader.GetString() ?? throw new JsonException();
 
-            if (Value.TryParse(textValue, out var value))
+            if (Value.TryParse(textValue, CultureInfo.InvariantCulture, out var value))
                 return value;
 
             throw new JsonException();
@@ -50,6 +65,12 @@ public override Value Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSe
         throw new JsonException();
     }
 
+    /// <summary>
+    /// Write a <see cref="Value"/> to the <paramref name="writer"/>.
+    /// </summary>
+    /// <param name="writer">Writer to write the <see cref="Value"/> to.</param>
+    /// <param name="value">The <see cref="Value"/> to write.</param>
+    /// <param name="options">An object that specifies serialization options to use.</param>
     public override void Write(Utf8JsonWriter writer, Value value, JsonSerializerOptions options)
     {
         writer.WriteStringValue(value.ToString());

src/Synercoding.Primitives/Point.cs

@@ -1,5 +1,6 @@
 using Synercoding.Primitives.Abstract;
 using System;
+using System.Diagnostics.CodeAnalysis;
 using System.Text.Json.Serialization;
 using System.Text.RegularExpressions;
 
@@ -9,7 +10,7 @@ namespace Synercoding.Primitives;
 /// A value type representing a point in a 2D space.
 /// </summary>
 [JsonConverter(typeof(JsonConverters.PointJsonConverter))]
-public readonly record struct Point : IConvertable<Point>, IEquatable<Point>
+public readonly record struct Point : IConvertable<Point>, IEquatable<Point>, IParsable<Point>
 {
     /// <summary>
     /// Constructor for a <see cref="Point"/>.
@@ -85,7 +86,15 @@ public bool Equals(Point other)
 
     /// <inheritdoc />
     public override string ToString()
-        => $"X: {X}, Y: {Y}";
+        => ToString(null);
+
+    /// <summary>
+    /// Returns a string representation of the point using the specified format provider.
+    /// </summary>
+    /// <param name="provider">The format provider to use for formatting numeric values.</param>  
+    /// <returns>A string representation of the point.</returns>
+    public string ToString(IFormatProvider? provider)
+        => $"X: {X.ToString(provider)}, Y: {Y.ToString(provider)}";
 
     /// <summary>
     /// Parse a string into a <see cref="Point"/>
@@ -94,8 +103,27 @@ public override string ToString()
     /// <returns>A <see cref="Point"/> that was represented by <paramref name="s"/>.</returns>
     /// <exception cref="ArgumentException">Throws if <paramref name="s"/> can not be parsed.</exception>
     public static Point Parse(string s)
+        => Parse(s, null);
+
+    /// <summary>
+    /// Try to converts a string representation of a <see cref="Point"/> into a <see cref="Point"/>.
+    /// </summary>
+    /// <param name="s"><see cref="string"/> to be parsed.</param>
+    /// <param name="point">Ref parameter with the parsed <see cref="Point"/>.</param>
+    /// <returns>A <see cref="bool"/> to indicate if the parsing was successful.</returns>
+    public static bool TryParse([NotNullWhen(true)] string? s, out Point point)
+        => TryParse(s, null, out point);
+
+    /// <summary>
+    /// Parse a string into a <see cref="Point"/>
+    /// </summary>
+    /// <param name="s"><see cref="string"/> to be parsed.</param>
+    /// <param name="provider">Format provider used when parsing values.</param>
+    /// <returns>A <see cref="Point"/> that was represented by <paramref name="s"/>.</returns>
+    /// <exception cref="ArgumentException">Throws if <paramref name="s"/> can not be parsed.</exception>
+    public static Point Parse(string s, IFormatProvider? provider)
     {
-        if (TryParse(s, out var value))
+        if (TryParse(s, provider, out var value))
             return value;
 
         throw new ArgumentException("Argument can't be parsed.", nameof(s));
@@ -105,20 +133,24 @@ public static Point Parse(string s)
     /// Try to converts a string representation of a <see cref="Point"/> into a <see cref="Point"/>.
     /// </summary>
     /// <param name="s"><see cref="string"/> to be parsed.</param>
-    /// <param name="point">Ref parameter with the parsed <see cref="Point"/>.</param>
+    /// <param name="provider">Format provider used when parsing values.</param>
+    /// <param name="result">Out parameter with the parsed <see cref="Point"/>.</param>
     /// <returns>A <see cref="bool"/> to indicate if the parsing was successful.</returns>
-    public static bool TryParse(string s, out Point point)
+    public static bool TryParse([NotNullWhen(true)] string? s, IFormatProvider? provider, [MaybeNullWhen(false)] out Point result)
     {
-        point = default;
+        result = default;
+
+        if (s is null)
+            return false;
 
         s = s.Trim();
 
         var match = Regex.Match(s, "^X: ?(.+), ?Y: ?(.+)$");
         if (match.Success && match.Groups.Count == 3)
         {
-            if (Value.TryParse(match.Groups[1].Value, out var x) && Value.TryParse(match.Groups[2].Value, out var y))
+            if (Value.TryParse(match.Groups[1].Value, provider, out var x) && Value.TryParse(match.Groups[2].Value, provider, out var y))
             {
-                point = new Point(x, y);
+                result = new Point(x, y);
                 return true;
             }
         }